Skip to content

Commit 31daf10

Browse files
committed
sql: implement hidden column element
TODO: Epic: CRDB-31283 Fixes: #139605 Release note (sql change): The `ALTER TABLE t ALTER COLUMN c SET [NOT] VISIBLE` statements now use the declarative schema changer.
1 parent e5714d0 commit 31daf10

File tree

19 files changed

+197
-3
lines changed

19 files changed

+197
-3
lines changed

pkg/ccl/logictestccl/tests/3node-tenant/generated_test.go

Lines changed: 7 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/ccl/logictestccl/tests/local-read-committed/generated_test.go

Lines changed: 7 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/ccl/logictestccl/tests/local-repeatable-read/generated_test.go

Lines changed: 7 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/cmd/roachtest/tests/mixed_version_job_compatibility_in_declarative_schema_changer.go

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -123,6 +123,12 @@ func executeSupportedDDLs(
123123
`ALTER TABLE testdb.testsc.t2 RENAME COLUMN k_renamed TO k`,
124124
}
125125

126+
// DDLs supported in V26_1.
127+
v261DDLs := []string{
128+
`ALTER TABLE testdb.testsc.t2 ALTER COLUMN j SET NOT VISIBLE`,
129+
`ALTER TABLE testdb.testsc.t2 ALTER COLUMN j SET VISIBLE`,
130+
}
131+
126132
// Used to clean up our CREATE-d elements after we are done with them.
127133
cleanup := []string{
128134
`DROP INDEX testdb.testsc.t@idx`,
@@ -155,6 +161,13 @@ func executeSupportedDDLs(
155161
}
156162
}
157163
}
164+
if clusterVersion.AtLeast(clusterversion.V26_1.Version()) {
165+
for _, ddl := range v261DDLs {
166+
if err := helper.ExecWithGateway(r, nodes, ddl); err != nil {
167+
return err
168+
}
169+
}
170+
}
158171

159172
for _, ddl := range cleanup {
160173
if err := helper.ExecWithGateway(r, nodes, ddl); err != nil {
Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
statement ok
2+
CREATE TABLE t (c1 INT8);
3+
CREATE TABLE u (c1 INT8);
4+
5+
query I colnames
6+
SELECT * FROM t
7+
----
8+
c1
9+
10+
statement ok
11+
DROP TABLE t
12+
13+
# FIXME: Why does the drop break this
14+
query ITTTT colnames
15+
SELECT * FROM u
16+
----
17+
c1 crdb_internal_mvcc_timestamp tableoid crdb_internal_origin_id crdb_internal_origin_timestamp

pkg/sql/logictest/tests/fakedist-disk/generated_test.go

Lines changed: 7 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/sql/logictest/tests/fakedist-vec-off/generated_test.go

Lines changed: 7 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/sql/logictest/tests/fakedist/generated_test.go

Lines changed: 7 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/sql/logictest/tests/local-legacy-schema-changer/generated_test.go

Lines changed: 7 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/sql/logictest/tests/local-mixed-25.2/generated_test.go

Lines changed: 7 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)