Skip to content

Commit 032bf32

Browse files
craig[bot]dils2kbghaljeffswensonrail
committed
155212: norm: rule to simplify const comparison with ANY values r=bghal a=dils2k Given a constant value compared using the ANY or SOME operators, we check for constants in the right hand side that can be used to simplify the comparison to True. For example, the expression: 0.1 < ANY (c0, 0.4) can now be simplified since 0.1 < 0.4. Fixes #132328 Release note: None Epic: CRDB-42979 156107: sql: add hidden column element r=bghal a=bghal This introduces a new schema changer element to manage the visibility of columns. That attribute was previously a field in the `Column` element. Epic: CRDB-31283 Part of: #139605 Release note: None 157951: jobs: fix TestJitterCalculation failed r=jeffswenson a=jeffswenson This test will sometimes fail due to a randomly picking a value that rounds to 1/2. The frequency of this is a bit higher than one would expect because the rounding behavior depends on the width of the duration, not the width of a float64. The test was adjusted to retry if the jittered value equals the input. Release note: none Fixes: #128381 Fixes: #157113 158064: release: fix redhat preflight component ID r=celiala a=rail Previously, the publish script was using PFLT_CERTIFICATION_PROJECT_ID to set the Red Hat preflight component ID, but it should be using PFLT_CERTIFICATION_COMPONENT_ID instead. This change corrects that environment variable to ensure proper functionality when publishing Red Hat releases. See redhat-openshift-ecosystem/openshift-preflight#1318 for the details. Epic: none Release note: none Co-authored-by: dils2k <[email protected]> Co-authored-by: Brendan Gerrity <[email protected]> Co-authored-by: Jeff Swenson <[email protected]> Co-authored-by: Rail Aliiev <[email protected]>
5 parents 545ce2c + cbd1c0a + bc48e89 + 4968c09 + e37904e commit 032bf32

File tree

140 files changed

+4516
-502
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

140 files changed

+4516
-502
lines changed

‎build/teamcity/internal/cockroach/release/publish/publish-redhat-release.sh‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ docker run \
8080
--env PFLT_LOGLEVEL=error \
8181
--env PFLT_ARTIFACTS=/artifacts \
8282
--env PFLT_LOGFILE=/artifacts/preflight.log \
83-
--env PFLT_CERTIFICATION_PROJECT_ID="$rhel_project_id" \
83+
--env PFLT_CERTIFICATION_COMPONENT_ID="$rhel_project_id" \
8484
--env PFLT_PYXIS_API_TOKEN="$REDHAT_API_TOKEN" \
8585
--env PFLT_DOCKERCONFIG=/temp-authfile.json \
8686
--env DOCKER_CONFIG=/tmp/docker \

‎pkg/ccl/schemachangerccl/testdata/decomp/multiregion‎

Lines changed: 75 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ ElementState:
129129
columnId: 2
130130
generatedAsIdentitySequenceOption: ""
131131
generatedAsIdentityType: 0
132-
isHidden: true
132+
isHidden: false
133133
isInaccessible: false
134134
isSystemColumn: false
135135
pgAttributeNum: 0
@@ -139,7 +139,7 @@ ElementState:
139139
columnId: 4.294967292e+09
140140
generatedAsIdentitySequenceOption: ""
141141
generatedAsIdentityType: 0
142-
isHidden: true
142+
isHidden: false
143143
isInaccessible: false
144144
isSystemColumn: true
145145
pgAttributeNum: 0
@@ -149,7 +149,7 @@ ElementState:
149149
columnId: 4.294967293e+09
150150
generatedAsIdentitySequenceOption: ""
151151
generatedAsIdentityType: 0
152-
isHidden: true
152+
isHidden: false
153153
isInaccessible: false
154154
isSystemColumn: true
155155
pgAttributeNum: 0
@@ -159,7 +159,7 @@ ElementState:
159159
columnId: 4.294967294e+09
160160
generatedAsIdentitySequenceOption: ""
161161
generatedAsIdentityType: 0
162-
isHidden: true
162+
isHidden: false
163163
isInaccessible: false
164164
isSystemColumn: true
165165
pgAttributeNum: 0
@@ -169,7 +169,7 @@ ElementState:
169169
columnId: 4.294967295e+09
170170
generatedAsIdentitySequenceOption: ""
171171
generatedAsIdentityType: 0
172-
isHidden: true
172+
isHidden: false
173173
isInaccessible: false
174174
isSystemColumn: true
175175
pgAttributeNum: 0
@@ -189,6 +189,26 @@ ElementState:
189189
name: primary
190190
tableId: 110
191191
Status: PUBLIC
192+
- ColumnHidden:
193+
columnId: 2
194+
tableId: 110
195+
Status: PUBLIC
196+
- ColumnHidden:
197+
columnId: 4.294967292e+09
198+
tableId: 110
199+
Status: PUBLIC
200+
- ColumnHidden:
201+
columnId: 4.294967293e+09
202+
tableId: 110
203+
Status: PUBLIC
204+
- ColumnHidden:
205+
columnId: 4.294967294e+09
206+
tableId: 110
207+
Status: PUBLIC
208+
- ColumnHidden:
209+
columnId: 4.294967295e+09
210+
tableId: 110
211+
Status: PUBLIC
192212
- ColumnName:
193213
columnId: 1
194214
name: b
@@ -523,7 +543,7 @@ ElementState:
523543
columnId: 2
524544
generatedAsIdentitySequenceOption: ""
525545
generatedAsIdentityType: 0
526-
isHidden: true
546+
isHidden: false
527547
isInaccessible: false
528548
isSystemColumn: false
529549
pgAttributeNum: 0
@@ -533,7 +553,7 @@ ElementState:
533553
columnId: 4.294967292e+09
534554
generatedAsIdentitySequenceOption: ""
535555
generatedAsIdentityType: 0
536-
isHidden: true
556+
isHidden: false
537557
isInaccessible: false
538558
isSystemColumn: true
539559
pgAttributeNum: 0
@@ -543,7 +563,7 @@ ElementState:
543563
columnId: 4.294967293e+09
544564
generatedAsIdentitySequenceOption: ""
545565
generatedAsIdentityType: 0
546-
isHidden: true
566+
isHidden: false
547567
isInaccessible: false
548568
isSystemColumn: true
549569
pgAttributeNum: 0
@@ -553,7 +573,7 @@ ElementState:
553573
columnId: 4.294967294e+09
554574
generatedAsIdentitySequenceOption: ""
555575
generatedAsIdentityType: 0
556-
isHidden: true
576+
isHidden: false
557577
isInaccessible: false
558578
isSystemColumn: true
559579
pgAttributeNum: 0
@@ -563,7 +583,7 @@ ElementState:
563583
columnId: 4.294967295e+09
564584
generatedAsIdentitySequenceOption: ""
565585
generatedAsIdentityType: 0
566-
isHidden: true
586+
isHidden: false
567587
isInaccessible: false
568588
isSystemColumn: true
569589
pgAttributeNum: 0
@@ -583,6 +603,26 @@ ElementState:
583603
name: primary
584604
tableId: 109
585605
Status: PUBLIC
606+
- ColumnHidden:
607+
columnId: 2
608+
tableId: 109
609+
Status: PUBLIC
610+
- ColumnHidden:
611+
columnId: 4.294967292e+09
612+
tableId: 109
613+
Status: PUBLIC
614+
- ColumnHidden:
615+
columnId: 4.294967293e+09
616+
tableId: 109
617+
Status: PUBLIC
618+
- ColumnHidden:
619+
columnId: 4.294967294e+09
620+
tableId: 109
621+
Status: PUBLIC
622+
- ColumnHidden:
623+
columnId: 4.294967295e+09
624+
tableId: 109
625+
Status: PUBLIC
586626
- ColumnName:
587627
columnId: 1
588628
name: a
@@ -953,7 +993,7 @@ ElementState:
953993
columnId: 3
954994
generatedAsIdentitySequenceOption: ""
955995
generatedAsIdentityType: 0
956-
isHidden: true
996+
isHidden: false
957997
isInaccessible: false
958998
isSystemColumn: false
959999
pgAttributeNum: 0
@@ -963,7 +1003,7 @@ ElementState:
9631003
columnId: 4.294967292e+09
9641004
generatedAsIdentitySequenceOption: ""
9651005
generatedAsIdentityType: 0
966-
isHidden: true
1006+
isHidden: false
9671007
isInaccessible: false
9681008
isSystemColumn: true
9691009
pgAttributeNum: 0
@@ -973,7 +1013,7 @@ ElementState:
9731013
columnId: 4.294967293e+09
9741014
generatedAsIdentitySequenceOption: ""
9751015
generatedAsIdentityType: 0
976-
isHidden: true
1016+
isHidden: false
9771017
isInaccessible: false
9781018
isSystemColumn: true
9791019
pgAttributeNum: 0
@@ -983,7 +1023,7 @@ ElementState:
9831023
columnId: 4.294967294e+09
9841024
generatedAsIdentitySequenceOption: ""
9851025
generatedAsIdentityType: 0
986-
isHidden: true
1026+
isHidden: false
9871027
isInaccessible: false
9881028
isSystemColumn: true
9891029
pgAttributeNum: 0
@@ -993,7 +1033,7 @@ ElementState:
9931033
columnId: 4.294967295e+09
9941034
generatedAsIdentitySequenceOption: ""
9951035
generatedAsIdentityType: 0
996-
isHidden: true
1036+
isHidden: false
9971037
isInaccessible: false
9981038
isSystemColumn: true
9991039
pgAttributeNum: 0
@@ -1021,6 +1061,26 @@ ElementState:
10211061
name: primary
10221062
tableId: 108
10231063
Status: PUBLIC
1064+
- ColumnHidden:
1065+
columnId: 3
1066+
tableId: 108
1067+
Status: PUBLIC
1068+
- ColumnHidden:
1069+
columnId: 4.294967292e+09
1070+
tableId: 108
1071+
Status: PUBLIC
1072+
- ColumnHidden:
1073+
columnId: 4.294967293e+09
1074+
tableId: 108
1075+
Status: PUBLIC
1076+
- ColumnHidden:
1077+
columnId: 4.294967294e+09
1078+
tableId: 108
1079+
Status: PUBLIC
1080+
- ColumnHidden:
1081+
columnId: 4.294967295e+09
1082+
tableId: 108
1083+
Status: PUBLIC
10241084
- ColumnName:
10251085
columnId: 1
10261086
name: k

‎pkg/ccl/schemachangerccl/testdata/decomp/partitioning‎

Lines changed: 40 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ ElementState:
6363
columnId: 4.294967292e+09
6464
generatedAsIdentitySequenceOption: ""
6565
generatedAsIdentityType: 0
66-
isHidden: true
66+
isHidden: false
6767
isInaccessible: false
6868
isSystemColumn: true
6969
pgAttributeNum: 0
@@ -73,7 +73,7 @@ ElementState:
7373
columnId: 4.294967293e+09
7474
generatedAsIdentitySequenceOption: ""
7575
generatedAsIdentityType: 0
76-
isHidden: true
76+
isHidden: false
7777
isInaccessible: false
7878
isSystemColumn: true
7979
pgAttributeNum: 0
@@ -83,7 +83,7 @@ ElementState:
8383
columnId: 4.294967294e+09
8484
generatedAsIdentitySequenceOption: ""
8585
generatedAsIdentityType: 0
86-
isHidden: true
86+
isHidden: false
8787
isInaccessible: false
8888
isSystemColumn: true
8989
pgAttributeNum: 0
@@ -93,7 +93,7 @@ ElementState:
9393
columnId: 4.294967295e+09
9494
generatedAsIdentitySequenceOption: ""
9595
generatedAsIdentityType: 0
96-
isHidden: true
96+
isHidden: false
9797
isInaccessible: false
9898
isSystemColumn: true
9999
pgAttributeNum: 0
@@ -110,6 +110,22 @@ ElementState:
110110
name: fam_0_pk_a_j
111111
tableId: 104
112112
Status: PUBLIC
113+
- ColumnHidden:
114+
columnId: 4.294967292e+09
115+
tableId: 104
116+
Status: PUBLIC
117+
- ColumnHidden:
118+
columnId: 4.294967293e+09
119+
tableId: 104
120+
Status: PUBLIC
121+
- ColumnHidden:
122+
columnId: 4.294967294e+09
123+
tableId: 104
124+
Status: PUBLIC
125+
- ColumnHidden:
126+
columnId: 4.294967295e+09
127+
tableId: 104
128+
Status: PUBLIC
113129
- ColumnName:
114130
columnId: 1
115131
name: pk
@@ -584,7 +600,7 @@ ElementState:
584600
columnId: 4.294967292e+09
585601
generatedAsIdentitySequenceOption: ""
586602
generatedAsIdentityType: 0
587-
isHidden: true
603+
isHidden: false
588604
isInaccessible: false
589605
isSystemColumn: true
590606
pgAttributeNum: 0
@@ -594,7 +610,7 @@ ElementState:
594610
columnId: 4.294967293e+09
595611
generatedAsIdentitySequenceOption: ""
596612
generatedAsIdentityType: 0
597-
isHidden: true
613+
isHidden: false
598614
isInaccessible: false
599615
isSystemColumn: true
600616
pgAttributeNum: 0
@@ -604,7 +620,7 @@ ElementState:
604620
columnId: 4.294967294e+09
605621
generatedAsIdentitySequenceOption: ""
606622
generatedAsIdentityType: 0
607-
isHidden: true
623+
isHidden: false
608624
isInaccessible: false
609625
isSystemColumn: true
610626
pgAttributeNum: 0
@@ -614,7 +630,7 @@ ElementState:
614630
columnId: 4.294967295e+09
615631
generatedAsIdentitySequenceOption: ""
616632
generatedAsIdentityType: 0
617-
isHidden: true
633+
isHidden: false
618634
isInaccessible: false
619635
isSystemColumn: true
620636
pgAttributeNum: 0
@@ -625,6 +641,22 @@ ElementState:
625641
name: primary
626642
tableId: 105
627643
Status: PUBLIC
644+
- ColumnHidden:
645+
columnId: 4.294967292e+09
646+
tableId: 105
647+
Status: PUBLIC
648+
- ColumnHidden:
649+
columnId: 4.294967293e+09
650+
tableId: 105
651+
Status: PUBLIC
652+
- ColumnHidden:
653+
columnId: 4.294967294e+09
654+
tableId: 105
655+
Status: PUBLIC
656+
- ColumnHidden:
657+
columnId: 4.294967295e+09
658+
tableId: 105
659+
Status: PUBLIC
628660
- ColumnName:
629661
columnId: 1
630662
name: a

0 commit comments

Comments
 (0)