Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

additionalParams not properly read #39

Open
CDRO opened this issue Nov 8, 2016 · 0 comments
Open

additionalParams not properly read #39

CDRO opened this issue Nov 8, 2016 · 0 comments

Comments

@CDRO
Copy link

CDRO commented Nov 8, 2016

Hello there,

I've stumbled accross a use case that isn't handled (at all) by linkhandler.

So what's happened to us is that a customer of ours wanted to link to a record and add a campaign parameter for the given link.

In order to do so, we added the following to the PageTS:

buttons.link.queryParametersSelector.enabled = 1

Now, this gives an additional field when browsing for links (for every possible link) that allows us to add any given additional parameter the customer wants.

BUT that case is not supported by the TypolinkHandler provided in 3.1.3, so we added it ourselves:

linkhandler/Classes/TypolinkHandler.php:132..134

        $additionalParams = explode('&', $linkParameterParts[2]);
        array_shift($additionalParams);
        $this->linkParameters['additionalParams'] .= '&' . implode('&', $additionalParams); 

Would it be possible for you to integrate this to the upcoming version?

Thanks for your feedback.

Tizian

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant