Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gitmate: Contextually sensitive actions on PRs #606

Open
jayvdb opened this issue Aug 2, 2018 · 4 comments
Open

Gitmate: Contextually sensitive actions on PRs #606

jayvdb opened this issue Aug 2, 2018 · 4 comments

Comments

@jayvdb
Copy link
Member

jayvdb commented Aug 2, 2018

Currently Gitmate adds a lot of noise to PRs.

It shouldnt repeat messages it has already put on PRs.

It could add a note to the existing message that the problem was seen again in the latest commit.

It should hide as 'Outdated' messages for errors which have been resolved.

etc

@nkprince007
Copy link
Member

nkprince007 commented Aug 2, 2018

Sorry, but I don't think I have enough time to spare to work on this right now. If anyone is willing to take over the issue, please do. I can provide assistance however.

@nkprince007 nkprince007 removed their assignment Aug 2, 2018
@Naveenaidu
Copy link
Member

@jayvdb Can i be assigned to this issue, If i can come up with a proper proposal for it?

@jayvdb
Copy link
Member Author

jayvdb commented Aug 3, 2018

@nkprince007 , I expect we would not try to get this project ready until long after GSoC. It would need to be assigned to / monitored by someone familiar with GitMate to ensure it comes as a reasonable project concept.

@Naveenaidu , it isnt ready to come up with a proposal yet. You contribute ideas here on the issue, and chat about it on coala or gitmate forums . At this stage, it is necessary to have a fairly good knowledge of coala & coala-bear changes over the last year, and gitmate changes over the last three months, to be confident your ideas are not already solved and not yet released, so chat is better than an issue discussion at this point.

I have only listed a few ways GitMate comments might be improved. We will need more deliverables in order to fill a three month project.

Currently gitmates value is reduced because of the volume and content of its messages 'drowning' the newbie.
Often newcomers close their PR and run away.

I think this project concept scope should be very explicitly not about improving the functionality of any GitMate plugins, but instead making them more useful by improving how those plugins errors are reported. i.e. a strictly UX project.

Many of the errors themselves will be improved when gitmate can use the upcoming release of coala & bears, so we shouldnt beg for ideas at this stage. We need to get coala & bears out, and into gitmate, and then get feedback on remaining UX problems.

@jayvdb jayvdb changed the title Gitmate: Contextually sensitive error comments on PRs Gitmate: Contextually sensitive actions on PRs Aug 3, 2018
@jayvdb
Copy link
Member Author

jayvdb commented Aug 3, 2018

Not sure if this has been fixed ..

cron jobs on travis trigger gitmate to relabel merged PRs.

This happens on our masters with cron jobs, and results in a gitter notification like gitmate-bot unlabeled #2649

Often the PR has no labelling change occur; it is just spurious notifications, probably because GitMate is adding the same label as already exists on the PR ('approved').

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants