Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FCL building in Github Actions uses wrong Python version #426

Closed
rayzchen opened this issue May 30, 2023 · 10 comments
Closed

FCL building in Github Actions uses wrong Python version #426

rayzchen opened this issue May 30, 2023 · 10 comments

Comments

@rayzchen
Copy link

rayzchen commented May 30, 2023

https://github.com/humanoid-path-planner/hpp-fcl/actions/runs/5054289798/jobs/9069053579#step:5:61, but the action for setup-miniconda is given and correctly sets up Python 3.7 (https://github.com/humanoid-path-planner/hpp-fcl/actions/runs/5054289798/jobs/9069053579#step:3:466)

@jcarpent
Copy link
Contributor

Thanks @rayzchen for raising this issue. I've just opened a new PR #427 fixing it.

@rayzchen
Copy link
Author

rayzchen commented May 30, 2023

I don't think that is going to fix the problem, since it is currently using Python 3.11 and disregarding the python-version option.

@jcarpent
Copy link
Contributor

Yes, you're right. I've updated the version of goanpeca/setup-miniconda.

@rayzchen
Copy link
Author

Is there a particular reason why goanpeca/setup-miniconda is used instead of conda-incubator/setup-miniconda?

@jcarpent
Copy link
Contributor

Except for historical reasons, no. I've just changed it.

@jcarpent
Copy link
Contributor

Fixed via #427.

@rayzchen
Copy link
Author

rayzchen commented May 30, 2023

I believe it still is creating a Python 3.11 module, since https://github.com/humanoid-path-planner/hpp-fcl/actions/runs/5122067821/jobs/9210618055#step:5:8654 shows that it cannot find hppfcl.hppfcl, which should point to a file called hppfcl.cp310-win_amd64.pyd, but the file found there (from my fork of this repo that saves the generated Python files) is called hppfcl.cp311-win_amd64.pyd. This would cause a ModuleNotFoundError in Python.

@jcarpent
Copy link
Contributor

Perfect. Thanks for the report. I was only looking at the cmake configuration.
I will look at it.

@jcarpent
Copy link
Contributor

@rayzchen I've found the issue which is not due to Conda and the CI, but rather the way we proceed for the packaging of the project. I will investigate it later with @fabinsch.

@rayzchen
Copy link
Author

Sorry, my bad, my fork had merge conflicts which weren't resolved correctly and still used v1 of the setup-miniconda action. Once fixed, the correct version of Python was used. It seems that I tried to link two separate problems together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants