-
Notifications
You must be signed in to change notification settings - Fork 72
config: CNF Installation (3) Switch to new config usage #2149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1a0267b
to
1a0a8a8
Compare
svteb
reviewed
Sep 20, 2024
dda4ac0
to
8eaee0e
Compare
bfe48fc
to
7d9bea3
Compare
81fae4c
to
448764e
Compare
List of changes: Most of changed *.cr files: adapt to new config (parsing, usage), won't be mentioned below.
|
ecd7158
to
5584abf
Compare
svteb
reviewed
Oct 3, 2024
src/tasks/utils/cnf_installation/config_updater/v1_to_v2_transformation.cr
Show resolved
Hide resolved
5584abf
to
0aad472
Compare
martin-mat
requested changes
Oct 3, 2024
0aad472
to
54fe61b
Compare
54fe61b
to
345b97d
Compare
Adapt all usages of config to the new format. Remove code that was used by old config. Update all sample and example configs. Refs: #2135 Signed-off-by: Konstantin Yarovoy <[email protected]>
345b97d
to
7959f4e
Compare
svteb
approved these changes
Oct 8, 2024
martin-mat
approved these changes
Oct 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
collivier
approved these changes
Oct 8, 2024
LuciaSirova
pushed a commit
that referenced
this pull request
Mar 27, 2025
Adapt all usages of config to the new format. Remove code that was used by old config. Update all sample and example configs. Refs: #2135 Signed-off-by: Konstantin Yarovoy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adapt all usages of config to the new config v2 format.
Remove code that was used by old config, but serves no purpose with new config version.
Update all sample and example configs, use transformer if cnf_setup is called with non-latest version.
Issues:
Refs: #2135