cnf_setup: Exit on setup failure or timeout #2114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kosstennbl
force-pushed
the
setup-failure-fix
branch
3 times, most recently
from
5f545b1 to
177531b
Compare
martin-mat
requested changes
Jul 29, 2024
kosstennbl
force-pushed
the
setup-failure-fix
branch
2 times, most recently
from
45a72e0 to
0ded1ba
Compare
martin-mat
requested changes
Jul 30, 2024
|
It looks that this change did its job and revealed issues with cnf setup in spec tests. They need to be addressed though. |
kosstennbl
force-pushed
the
setup-failure-fix
branch
from
0ded1ba to
4288cc9
Compare
|
Issues with "envoy" chart are brought by #2116, they should be resolved for CI to pass. |
|
the change looks fine for me now, I will approve after the envoy issue is addressed. |
kosstennbl
force-pushed
the
setup-failure-fix
branch
from
4288cc9 to
6f10c63
Compare
|
rebase pls |
kosstennbl
force-pushed
the
setup-failure-fix
branch
2 times, most recently
from
f26345d to
c5c49f6
Compare
martin-mat
requested review from
taylor,
rich-l,
Smitholi67,
svteb and
horecoli
martin-mat
requested changes
Aug 6, 2024
kosstennbl
force-pushed
the
setup-failure-fix
branch
from
c5c49f6 to
96429b1
Compare
kosstennbl
force-pushed
the
setup-failure-fix
branch
from
96429b1 to
46731ce
Compare
kosstennbl
force-pushed
the
setup-failure-fix
branch
from
46731ce to
2db676d
Compare
Fix handling unsuccessful cnf setup, if resources are not ready after timeout - then setup should fail with exit 1. Change specs accordingly, replace wait_count=0 with new option "ignore_setup_timeout". Add cnf_setup function to ShellCmd and use it for installation of CNFs during specs. Refs: lfn-cnti#1937 lfn-cnti#2083 Signed-off-by: Konstantin Yarovoy <[email protected]>
kosstennbl
force-pushed
the
setup-failure-fix
branch
from
2db676d to
ead9a9e
Compare
martin-mat
added a commit
to martin-mat/cnf-testsuite
that referenced
this pull request
Aug 16, 2024
After lfn-cnti#2114 was merged, an issue was revealed with image size - protected repo spec test. It was discovered only after merging. Until this is fixed, disabling this variant of the image size spec test. Refs: lfn-cnti#2114 lfn-cnti#2136 Signed-off-by: Martin Matyas <[email protected]>
martin-mat
added a commit
to martin-mat/cnf-testsuite
that referenced
this pull request
Aug 16, 2024
After lfn-cnti#2114 was merged, an issue was revealed with image size - protected repo spec test. It was discovered only after merging. Until this is fixed, disabling this variant of the image size spec test. Refs: lfn-cnti#2114 lfn-cnti#2136 Signed-off-by: Martin Matyas <[email protected]>
martin-mat
added a commit
that referenced
this pull request
Aug 16, 2024
After #2114 was merged, an issue was revealed with image size - protected repo spec test. It was discovered only after merging. Until this is fixed, disabling this variant of the image size spec test. Refs: #2114 #2136 Signed-off-by: Martin Matyas <[email protected]>
This was referenced Aug 19, 2024
LuciaSirova
pushed a commit
that referenced
this pull request
Mar 27, 2025
Fix handling unsuccessful cnf setup, if resources are not ready after timeout - then setup should fail with exit 1. Change specs accordingly, replace wait_count=0 with new option "ignore_setup_timeout". Add cnf_setup function to ShellCmd and use it for installation of CNFs during specs. Refs: #1937 #2083 Signed-off-by: Konstantin Yarovoy <[email protected]>
LuciaSirova
pushed a commit
that referenced
this pull request
Mar 27, 2025
After #2114 was merged, an issue was revealed with image size - protected repo spec test. It was discovered only after merging. Until this is fixed, disabling this variant of the image size spec test. Refs: #2114 #2136 Signed-off-by: Martin Matyas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix handling unsuccessful cnf setup, if resources are not ready after timeout - then setup should fail with exit 1.
Change specs accordingly, replace wait_count=0 with new option "ignore_setup_timeout".
Add cnf_setup function to ShellCmd and use it for installation of CNFs during specs.
Issues:
Refs: #1937 #2083