Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hardcoded-ip-test: Redesign test, add more info on fail #2096

Conversation

kosstennbl
Copy link
Collaborator

Description

Add information about file location, line numbers and lines themselves if the hardcoded_ip_addresses_in_k8s_runtime_configuration fails

Issues:

Refs: #2093

How has this been tested:

Covered by existing integration testing

Types of changes:

Bug fix (non-breaking change which fixes an issue)

@kosstennbl kosstennbl requested a review from martin-mat July 1, 2024 13:38
@kosstennbl kosstennbl force-pushed the hardcoded-ip-non-informative-fix branch from 17475d3 to 1808f0f Compare July 1, 2024 13:40
src/tasks/workload/configuration.cr Outdated Show resolved Hide resolved
src/tasks/workload/configuration.cr Outdated Show resolved Hide resolved
@kosstennbl kosstennbl force-pushed the hardcoded-ip-non-informative-fix branch from 1808f0f to ed666ba Compare July 2, 2024 14:07
@martin-mat martin-mat self-requested a review July 2, 2024 14:16
Copy link
Collaborator

@martin-mat martin-mat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

@rich-l rich-l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Add information about file location, line numbers and lines themselves
if the hardcoded_ip_addresses_in_k8s_runtime_configuration fails

Refs: cnti-testcatalog#2093
Signed-off-by: Konstantin Yarovoy <[email protected]>
@kosstennbl kosstennbl force-pushed the hardcoded-ip-non-informative-fix branch from ed666ba to 0a26837 Compare July 3, 2024 10:10
@martin-mat martin-mat merged commit bf7e258 into cnti-testcatalog:main Jul 3, 2024
87 checks passed
@kosstennbl kosstennbl deleted the hardcoded-ip-non-informative-fix branch July 11, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants