Skip to content

Bump kubectl_client to fix labelling issue #2085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

martin-mat
Copy link
Collaborator

Refs: #2062

How has this been tested:

  • Covered by existing integration testing
  • Added integration testing to cover
  • Verified all A/C passes
    • develop
    • master
    • tag/other branch
  • Test environment
    • Shared Packet K8s cluster
    • New Packet K8s cluster
    • Kind cluster
  • Have not tested

Types of changes:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

Documentation

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • No updates required.

Code Review

  • Does the test handle fatal exceptions, ie. rescue block

Issue

  • Tasks in issue are checked off

@martin-mat
Copy link
Collaborator Author

Copy link
Collaborator

@electrocucaracha electrocucaracha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new version has been created

Copy link
Contributor

@horecoli horecoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but what about conflict in shards, where other libraries used this kubectl_client? Is it somehow fixed?

@martin-mat
Copy link
Collaborator Author

what about conflict in shards, where other libraries used this kubectl_client? Is it somehow fixed?

Right version of kubectl_client is installed, see below.
shards.yml anywhere in libs does not prevent it (dependencies states just a lowest version) and it looks shards.lock is taken only from primary repo, not from libs (or at least shards gives it higher priority than those in libs)

shards --without-development install
Resolving dependencies
Fetching https://github.com/vulk/sam.cr.git
Fetching https://github.com/icyleaf/halite.git
Fetching https://github.com/crystal-community/icr.git
Fetching https://github.com/icyleaf/totem.git
Fetching https://github.com/sija/retriable.cr.git
Fetching https://github.com/mrrooijen/commander.git
Fetching https://github.com/cnf-testsuite/tar.git
Fetching https://github.com/cnf-testsuite/find.git
Fetching https://github.com/cnf-testsuite/git.git
Fetching https://github.com/cnf-testsuite/docker_client.git
Fetching https://github.com/cnf-testsuite/kubectl_client.git
Fetching https://github.com/cnf-testsuite/cluster_tools.git
Fetching https://github.com/cnf-testsuite/kernel_introspection.git
Fetching https://github.com/cnf-testsuite/k8s_kernel_introspection.git
Fetching https://github.com/cnf-testsuite/k8s_netstat.git
Fetching https://github.com/cnf-testsuite/helm.git
Fetching https://github.com/cnf-testsuite/release_manager.git
Fetching https://github.com/jeromegn/protobuf.cr.git
Fetching https://github.com/icyleaf/popcorn.git
Fetching https://github.com/crystal-lang/crystal-readline.git
Shard "kubectl_client" version (1.0.6) doesn't match tag version (1.0.7)
Shard "kubectl_client" version (1.0.6) doesn't match tag version (1.0.7)
Shard "kubectl_client" version (1.0.6) doesn't match tag version (1.0.7)
Shard "cluster_tools" version (1.0.0) doesn't match tag version (1.0.5)
Using sam (0.4.0 at 4e3b271)
Using readline (0.1.1 at 69ecf33)
Using icr (0.9.0 at f62bfcd)
Using commander (0.4.0)
Using retriable (0.2.5)
Using popcorn (0.3.0)
Using totem (0.7.0)
Using git (1.0.0)
Using kernel_introspection (0.1.0)
Using docker_client (1.0.0)
Using kubectl_client (1.0.7)
Using cluster_tools (1.0.5)
Using k8s_kernel_introspection (1.0.2)
Using halite (0.12.1)
Using find (0.1.0 at 129096c)
Using tar (0.1.0 at ae9bbea)
Using helm (1.0.2)
Using k8s_netstat (1.0.0)
Using release_manager (0.1.0 at a1d7b35)
Using airgap (0.1.0 at utils/airgap)
Using protobuf (2.3.0)
Writing shard.lock

Copy link
Collaborator

@kosstennbl kosstennbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for the explanation above

@martin-mat martin-mat merged commit 0337260 into lfn-cnti:main Jun 25, 2024
2 of 88 checks passed
LuciaSirova pushed a commit that referenced this pull request Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants