Remove -ti in docker and kubectl calls #1984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It avoids passing stdin to the container when useless. Please note it removes a couple of issues highlighted by [1] in airgap specs. It also removes all useless blank chars in the files modified by this change. [1] cnti-testcatalog#1949 Signed-off-by: Cédric Ollivier <[email protected]>
collivier
requested review from
denverwilliams,
wvwatson,
agentpoyo and
HashNuke
as code owners
|
@HashNuke would you mind running the specs in your branch. I ran a few specs locally but this change requires a full verification. Thank you in advance. |
|
Resolved conflict by commenting out airgap specs as in main branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It avoids passing stdin to the container when useless.
Please note it removes a couple of issues highlighted by [1] in airgap specs.
It also removes all useless blank chars in the files modified by this change.
[1] #1949
How has this been tested:
Types of changes: