-
Notifications
You must be signed in to change notification settings - Fork 72
Removal of allowlist from priviledged tests #1928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you for the updates. Waiting for the build to run for the main branch. I will re-run this build once the main branch is green - https://github.com/cnti-testcatalog/testsuite/actions/runs/8345433746 |
Needs further discussion and updates |
@taylor, maybe you are right to have such exceptions in some cases. But the question is whether the allowlisting has to be done per-test or if there should be a common list of exceptions. Because as it is right now, we are giving the user the ability to make this test pass at any time. However, on the other side, there has to be motivation for the user to follow this best practice and refrain from making fraudulent attempts to pass the test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Remove updates in this PR which remove the feature allowlist -> we are keeping the feature
- manually test that each example CNFs pass the privilege mode test -> they are not checked by specs
252d720
to
5905b3f
Compare
lgtm |
This change is more or less done, but I am still verifying if all tests are running as expected. |
@horecoli rebase and this should be good to merge. cc: @agentpoyo @HashNuke |
5905b3f
to
a2462ec
Compare
a2462ec
to
288a146
Compare
288a146
to
57ae261
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Some sample CNFs still have empty arrays:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This change updates privileged test to consider only containers from CNF under test. As a result of this change, the 'allowlist_helm_chart_container_names' parameter in the cnf-testsuite.yml configuration file of lot of examples and samples is no needed. Therefore this patch also removes this parameter from cnf-testsuite.yml in examples and samples where it is no need anymore. Closes-Bug: lfn-cnti#1906 Signed-off-by: horecoli <[email protected]>
57ae261
to
9111444
Compare
Those two samples were added after I created this PR, so at that time, they were not there. And now I just rebased and forgot to do some grep to check if there is something new. So I fixed it in the latest change. Thank you :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs CI rerun, otherwise - LGTM
This change updates privileged test to consider only containers from CNF under test. As a result of this change, the 'allowlist_helm_chart_container_names' parameter in the cnf-testsuite.yml configuration file of lot of examples and samples is no needed. Therefore this patch also removes this parameter from cnf-testsuite.yml in examples and samples where it is no need anymore. Closes-Bug: lfn-cnti#1906 Signed-off-by: horecoli <[email protected]>
This change updates privileged test to consider only containers from CNF under test. As a result of this change, the 'allowlist_helm_chart_container_names' parameter in the cnf-testsuite.yml configuration file of lot of examples and samples is no needed. Therefore this patch also removes this parameter from cnf-testsuite.yml in examples and samples where it is no need anymore. Closes-Bug: lfn-cnti#1906 Signed-off-by: horecoli <[email protected]>
This change updates privileged test to consider only containers from CNF under test. As a result of this change, the 'allowlist_helm_chart_container_names' parameter in the cnf-testsuite.yml configuration file of lot of examples and samples is no needed. Therefore this patch also removes this parameter from cnf-testsuite.yml in examples and samples where it is no need anymore. Closes-Bug: #1906 Signed-off-by: horecoli <[email protected]>
Description
This change updates priviledged test to consider
only containers from CNF under test. As a result of this change, the 'allowlist_helm_chart_container_names' parameter in the cnf-testsuite.yml configuration file is no longer needed.
Therefore this patch also removes this parameter from the configuration, as well as from all samples and examples.
Issues:
Refs: #1906
How has this been tested:
Types of changes:
Checklist:
Documentation
Code Review
Issue