-
Notifications
You must be signed in to change notification settings - Fork 72
[Feature] CNF Installation (6), Prepare new installation process #2161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
enhancement
New feature or request
Comments
Some chaotic development ideas, written in the issue to not be lost in time and local notes:
Deployment installers:
HelmDirectory:
ManifestDirectory:
Installation method for helm deployments:
|
Things to not forget about:
|
kosstennbl
pushed a commit
that referenced
this issue
Oct 14, 2024
Create new CNF installation process, that will support multiple deployments, be more comprehensible and easier to maintain. Don't replace the old one yet, both installation methods should exist simultaneously Refs: #2161 Signed-off-by: Konstantin Yarovoy <[email protected]>
kosstennbl
pushed a commit
that referenced
this issue
Oct 14, 2024
Create new CNF installation process, that will support multiple deployments, be more comprehensible and easier to maintain. Don't replace the old one yet, both installation methods should exist simultaneously Refs: #2161 Signed-off-by: Konstantin Yarovoy <[email protected]>
kosstennbl
pushed a commit
that referenced
this issue
Oct 14, 2024
Create new CNF installation process, that will support multiple deployments, be more comprehensible and easier to maintain. Don't replace the old one yet, both installation methods should exist simultaneously Refs: #2161 Signed-off-by: Konstantin Yarovoy <[email protected]>
kosstennbl
pushed a commit
that referenced
this issue
Oct 15, 2024
Create new CNF installation process, that will support multiple deployments, be more comprehensible and easier to maintain. Don't replace the old one yet, both installation methods should exist simultaneously Refs: #2161 Signed-off-by: Konstantin Yarovoy <[email protected]>
kosstennbl
pushed a commit
that referenced
this issue
Oct 16, 2024
Create new CNF installation process, that will support multiple deployments, be more comprehensible and easier to maintain. Don't replace the old one yet, both installation methods should exist simultaneously Refs: #2161 Signed-off-by: Konstantin Yarovoy <[email protected]>
kosstennbl
pushed a commit
that referenced
this issue
Oct 18, 2024
Create new CNF installation process, that will support multiple deployments, be more comprehensible and easier to maintain. Don't replace the old one yet, both installation methods should exist simultaneously Refs: #2161 Signed-off-by: Konstantin Yarovoy <[email protected]>
kosstennbl
pushed a commit
that referenced
this issue
Oct 18, 2024
Create new CNF installation process, that will support multiple deployments, be more comprehensible and easier to maintain. Don't replace the old one yet, both installation methods should exist simultaneously Refs: #2161 Signed-off-by: Konstantin Yarovoy <[email protected]>
kosstennbl
pushed a commit
that referenced
this issue
Oct 18, 2024
Create new CNF installation process, that will support multiple deployments, be more comprehensible and easier to maintain. Don't replace the old one yet, both installation methods should exist simultaneously Refs: #2161 Signed-off-by: Konstantin Yarovoy <[email protected]>
kosstennbl
pushed a commit
that referenced
this issue
Oct 18, 2024
Create new CNF installation process, that will support multiple deployments, be more comprehensible and easier to maintain. Don't replace the old one yet, both installation methods should exist simultaneously Refs: #2161 Signed-off-by: Konstantin Yarovoy <[email protected]>
kosstennbl
pushed a commit
that referenced
this issue
Oct 21, 2024
Create new CNF installation process, that will support multiple deployments, be more comprehensible and easier to maintain. Don't replace the old one yet, both installation methods should exist simultaneously Refs: #2161 Signed-off-by: Konstantin Yarovoy <[email protected]>
kosstennbl
pushed a commit
that referenced
this issue
Oct 21, 2024
Create new CNF installation process, that will support multiple deployments, be more comprehensible and easier to maintain. Don't replace the old one yet, both installation methods should exist simultaneously Refs: #2161 Signed-off-by: Konstantin Yarovoy <[email protected]>
kosstennbl
pushed a commit
that referenced
this issue
Oct 25, 2024
Create new CNF installation process, that will support multiple deployments, be more comprehensible and easier to maintain. Don't replace the old one yet, both installation methods should exist simultaneously Refs: #2161 Signed-off-by: Konstantin Yarovoy <[email protected]>
kosstennbl
pushed a commit
that referenced
this issue
Oct 29, 2024
Create new CNF installation process, that will support multiple deployments, be more comprehensible and easier to maintain. Don't replace the old one yet, both installation methods should exist simultaneously Refs: #2161 Signed-off-by: Konstantin Yarovoy <[email protected]>
kosstennbl
pushed a commit
that referenced
this issue
Oct 31, 2024
Create new CNF installation process, that will support multiple deployments, be more comprehensible and easier to maintain. Don't replace the old one yet, both installation methods should exist simultaneously Refs: #2161 Signed-off-by: Konstantin Yarovoy <[email protected]>
kosstennbl
pushed a commit
that referenced
this issue
Nov 6, 2024
Create new CNF installation process, that will support multiple deployments, be more comprehensible and easier to maintain. Don't replace the old one yet, both installation methods should exist simultaneously Refs: #2161 Signed-off-by: Konstantin Yarovoy <[email protected]>
martin-mat
pushed a commit
that referenced
this issue
Nov 7, 2024
Create new CNF installation process, that will support multiple deployments, be more comprehensible and easier to maintain. Don't replace the old one yet, both installation methods should exist simultaneously Refs: #2161 Signed-off-by: Konstantin Yarovoy <[email protected]>
svteb
added a commit
that referenced
this issue
Nov 12, 2024
Refs: #2168 - New setup spec tests were introduced to verify that the installation method from #2161 works as intended. - Three distinct issues were discovered and resolved: * Helm directories with variable depth levels could not be discovered after initialization (resolved through File.basename). * Configs that weren't named cnf-testsuite.yml could not be discovered after initialization (resolved by changing the name internally when copying the file). * Existence of manifest folder was not checked (resolved by adding an if check). - Additionally a common point of failure was added with a failure message that was previously not present. - The issue #2176 was also discovered during attempted deployment of sample-cnfs/sample-elk-stack which was also added in this commit and is to be used in future spec test. Signed-off-by: svteb <[email protected]>
20 tasks
svteb
added a commit
that referenced
this issue
Nov 13, 2024
Refs: #2168 - New setup spec tests were introduced to verify that the installation method from #2161 works as intended. - Three distinct issues were discovered and resolved: * Helm directories with variable depth levels could not be discovered after initialization (resolved through File.basename). * Configs that weren't named cnf-testsuite.yml could not be discovered after initialization (resolved by changing the name internally when copying the file). * Existence of manifest folder was not checked (resolved by adding an if check). - Additionally a common point of failure was added with a failure message that was previously not present. - The issue #2176 was also discovered during attempted deployment of sample-cnfs/sample-elk-stack which was also added in this commit and is to be used in future spec test. Signed-off-by: svteb <[email protected]>
svteb
added a commit
that referenced
this issue
Nov 14, 2024
Refs: #2168 - New setup spec tests were introduced to verify that the installation method from #2161 works as intended. - Three distinct issues were discovered and resolved: * Helm directories with variable depth levels could not be discovered after initialization (resolved through File.basename). * Configs that weren't named cnf-testsuite.yml could not be discovered after initialization (resolved by changing the name internally when copying the file). * Existence of manifest folder was not checked (resolved by adding an if check). - Additionally a common point of failure was added with a failure message that was previously not present. - The issue #2176 was also discovered during attempted deployment of sample-cnfs/sample-elk-stack which was also added in this commit and is to be used in future spec test. Signed-off-by: svteb <[email protected]>
Done in #2165 |
collivier
pushed a commit
that referenced
this issue
Nov 27, 2024
Refs: #2168 - New setup spec tests were introduced to verify that the installation method from #2161 works as intended. - Three distinct issues were discovered and resolved: * Helm directories with variable depth levels could not be discovered after initialization (resolved through File.basename). * Configs that weren't named cnf-testsuite.yml could not be discovered after initialization (resolved by changing the name internally when copying the file). * Existence of manifest folder was not checked (resolved by adding an if check). - Additionally a common point of failure was added with a failure message that was previously not present. - The issue #2176 was also discovered during attempted deployment of sample-cnfs/sample-elk-stack which was also added in this commit and is to be used in future spec test. Signed-off-by: svteb <[email protected]>
svteb
added a commit
that referenced
this issue
Nov 28, 2024
Refs: #2168 - New setup spec tests were introduced to verify that the installation method from #2161 works as intended. - Three distinct issues were discovered and resolved: * Helm directories with variable depth levels could not be discovered after initialization (resolved through File.basename). * Configs that weren't named cnf-testsuite.yml could not be discovered after initialization (resolved by changing the name internally when copying the file). * Existence of manifest folder was not checked (resolved by adding an if check). - Additionally a common point of failure was added with a failure message that was previously not present. - The issue #2176 was also discovered during attempted deployment of sample-cnfs/sample-elk-stack which was also added in this commit and is to be used in future spec test. Signed-off-by: svteb <[email protected]>
LuciaSirova
pushed a commit
that referenced
this issue
Mar 27, 2025
Create new CNF installation process, that will support multiple deployments, be more comprehensible and easier to maintain. Don't replace the old one yet, both installation methods should exist simultaneously Refs: #2161 Signed-off-by: Konstantin Yarovoy <[email protected]>
LuciaSirova
pushed a commit
that referenced
this issue
Mar 27, 2025
Refs: #2168 - New setup spec tests were introduced to verify that the installation method from #2161 works as intended. - Three distinct issues were discovered and resolved: * Helm directories with variable depth levels could not be discovered after initialization (resolved through File.basename). * Configs that weren't named cnf-testsuite.yml could not be discovered after initialization (resolved by changing the name internally when copying the file). * Existence of manifest folder was not checked (resolved by adding an if check). - Additionally a common point of failure was added with a failure message that was previously not present. - The issue #2176 was also discovered during attempted deployment of sample-cnfs/sample-elk-stack which was also added in this commit and is to be used in future spec test. Signed-off-by: svteb <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
To support multiple deployments as one CNF, we need to design a new installation process.
Main idea of this new process is creating separate methods for each deployment type and then install all deployments from config on one-by-one basis.
All related files and methods should be created in cnf_installation directory.
If and where possible, code for HelmDirectory deployments should be reused for HelmChart deployments
On this step, old installation methods should NOT be removed or manipulated in any way. All new functionality should be added under different SAM tasks, possibly with some required ENV (e.g. ENV["CRYSTAL_ENV"] = "EXPERIMENTAL", we use that ENV for testing.)
The text was updated successfully, but these errors were encountered: