Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

less strict requirements, if needed, for security reviewers #142

Closed
ultrasaurus opened this issue Apr 12, 2019 · 5 comments
Closed

less strict requirements, if needed, for security reviewers #142

ultrasaurus opened this issue Apr 12, 2019 · 5 comments
Labels
assessment-process proposed improvements to security assessment process inactive No activity on issue/PR

Comments

@ultrasaurus
Copy link
Member

At the moment, we can consider ourselves in "bootstrap" mode. The following qualification are a bit more representative of the current working group and could serve to facilitate a reasonable process if needed.

Qualifications

WG will strive to establish that the two mentors have diverse experience, covering some of the ideal qualifications below. Exemptions may be granted by the WG chairs, expected to bootstrap the process but only in extreme cases later on.

To aid in this process, WG members are encouraged to provide a profile with a synopsis of their background with respect to their relevant experience.

Requirements

  • Participation in a security audit
  • Participated in prior SAFE Assessment

Ideal

  • performed security audits for diverse organizations
  • the recipient of security audits for a software project they manage
  • experience using and contributing to open source

Note that it is encouraged to have participation (shadowing) from participants that are not
yet qualified to help them gain the necessary skills to be a SAFE mentor in the future.

@ultrasaurus ultrasaurus added the assessment-process proposed improvements to security assessment process label Apr 12, 2019
@lizrice
Copy link
Contributor

lizrice commented Apr 12, 2019

Is this qualification to be a member, or to be a mentor?

@ultrasaurus
Copy link
Member Author

to be a mentor... latest idea is to simply call this role a "security reviewer" . -- should have referenced PR: https://github.com/cn-security/safe/pull/125/files#diff-e986a9a43ab06061c021c47c9a089b32

@ultrasaurus ultrasaurus changed the title less strict requirements, if needed, for assessment process less strict requirements, if needed, for security reviewers Apr 12, 2019
@rficcaglia
Copy link
Contributor

rficcaglia commented Apr 21, 2019

perhaps instead of "strict" or other qualitative attributes, we enumerate the specific skills desired for a given review, eg:

  • crypto expertise
  • distributed protocol expertise
  • kernel implementation experience
  • network protocol expertise
  • mathematical proofs
  • whitehat/blackhat experience
  • secure code reviews
  • etc

and allow volunteers to self-identify with those skills via some tangible evidence:

  • a public/published article on the topic
  • public commits or GHIs to another open source project
  • a verifiable (or at least identifiable) recommendation via a GHI or PR from the recommender
  • a vuln/CVE report in their name
  • etc

then it becomes more of a mapping exercise of selecting a review team with members that cover the specific skills needed, recognizing that very few will have all the necessary (deep) domain expertise for a given review.

@stale
Copy link

stale bot commented Mar 17, 2020

This issue has been automatically marked as inactive because it has not had recent activity.

@stale stale bot added the inactive No activity on issue/PR label Mar 17, 2020
@TheFoxAtWork
Copy link
Collaborator

Closing as overcome by events. Recent Security Assessment process updates refined this a little and seems to work for now. Can reopen/revisit later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assessment-process proposed improvements to security assessment process inactive No activity on issue/PR
Projects
None yet
Development

No branches or pull requests

4 participants