Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: Inv Image validation should use docker/distribution to parse #196

Open
vdice opened this issue Mar 4, 2020 · 0 comments
Open

Refactor: Inv Image validation should use docker/distribution to parse #196

vdice opened this issue Mar 4, 2020 · 0 comments

Comments

@vdice
Copy link
Member

vdice commented Mar 4, 2020

Currently, in func (img InvocationImage) Validate() from bundle/bundle.go, we validate an image type is docker or oci via a custom validateDockerish function. We should remove this and use Parse from docker/distribution instead. For further context, see #191 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vdice