Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use alpaka methods #79

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Conversation

AuroraPerego
Copy link
Contributor

these methods are implemented in alpaka now, so we can use them directly

@@ -34,11 +34,11 @@
TilesAlpaka<Ndim>* tiles,
uint32_t nTiles,
uint32_t nPerDim) const {
if (clue::once_per_grid(acc)) {
if (alpaka::oncePerGrid(acc)) {

Check notice

Code scanning / Cppcheck (reported by Codacy)

MISRA 14.4 rule Note

MISRA 14.4 rule
tiles->resizeTiles(nTiles, nPerDim);
}
clue::for_each_element_in_grid(
acc, nTiles, [&](uint32_t i) -> void { tiles->clear(i); });
for (auto index : alpaka::uniformElements(acc, nTiles))

Check notice

Code scanning / Cppcheck (reported by Codacy)

MISRA 15.6 rule Note

MISRA 15.6 rule
@@ -47,8 +47,8 @@
ALPAKA_FN_ACC void operator()(const TAcc& acc,
VecArray<int, max_followers>* d_followers,
uint32_t n_points) const {
clue::for_each_element_in_grid(
acc, n_points, [&](uint32_t i) { d_followers[i].reset(); });
for (auto index : alpaka::uniformElements(acc, n_points))

Check notice

Code scanning / Cppcheck (reported by Codacy)

MISRA 15.6 rule Note

MISRA 15.6 rule
getCoords<Ndim>(coords, points, i);
tiles->fill(acc, coords, i);
});
getCoords<Ndim>(coords, points, index);

Check notice

Code scanning / Cppcheck (reported by Codacy)

Avoid laying out strings in memory directly before sensitive data Note

Avoid laying out strings in memory directly before sensitive data
tiles->fill(acc, coords, i);
});
getCoords<Ndim>(coords, points, index);
tiles->fill(acc, coords, index);

Check notice

Code scanning / Cppcheck (reported by Codacy)

Avoid laying out strings in memory directly before sensitive data Note

Avoid laying out strings in memory directly before sensitive data
@sbaldu sbaldu merged commit ad459ad into cms-patatrack:main Jan 24, 2025
20 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants