-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use alpaka methods #79
Conversation
@@ -34,11 +34,11 @@ | |||
TilesAlpaka<Ndim>* tiles, | |||
uint32_t nTiles, | |||
uint32_t nPerDim) const { | |||
if (clue::once_per_grid(acc)) { | |||
if (alpaka::oncePerGrid(acc)) { |
Check notice
Code scanning / Cppcheck (reported by Codacy)
MISRA 14.4 rule Note
tiles->resizeTiles(nTiles, nPerDim); | ||
} | ||
clue::for_each_element_in_grid( | ||
acc, nTiles, [&](uint32_t i) -> void { tiles->clear(i); }); | ||
for (auto index : alpaka::uniformElements(acc, nTiles)) |
Check notice
Code scanning / Cppcheck (reported by Codacy)
MISRA 15.6 rule Note
@@ -47,8 +47,8 @@ | |||
ALPAKA_FN_ACC void operator()(const TAcc& acc, | |||
VecArray<int, max_followers>* d_followers, | |||
uint32_t n_points) const { | |||
clue::for_each_element_in_grid( | |||
acc, n_points, [&](uint32_t i) { d_followers[i].reset(); }); | |||
for (auto index : alpaka::uniformElements(acc, n_points)) |
Check notice
Code scanning / Cppcheck (reported by Codacy)
MISRA 15.6 rule Note
getCoords<Ndim>(coords, points, i); | ||
tiles->fill(acc, coords, i); | ||
}); | ||
getCoords<Ndim>(coords, points, index); |
Check notice
Code scanning / Cppcheck (reported by Codacy)
Avoid laying out strings in memory directly before sensitive data Note
tiles->fill(acc, coords, i); | ||
}); | ||
getCoords<Ndim>(coords, points, index); | ||
tiles->fill(acc, coords, index); |
Check notice
Code scanning / Cppcheck (reported by Codacy)
Avoid laying out strings in memory directly before sensitive data Note
cd32b31
to
720b672
Compare
these methods are implemented in alpaka now, so we can use them directly