Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deno 2.0 compatiblity #46

Open
dxdye opened this issue Nov 10, 2024 · 0 comments
Open

Deno 2.0 compatiblity #46

dxdye opened this issue Nov 10, 2024 · 0 comments

Comments

@dxdye
Copy link

dxdye commented Nov 10, 2024

Issue

Setup:

  • Deno Version: 2.0.5
  • v8 Version: 11.3.244.8-node.23
  • Typescript Version: 5.1.3
  • SuperDeno Version: 4.9.0

Details

Since Deno 2.0 was released a couple of weeks ago, I made some changes to the code, which make it compatible to this version.
Feel free to review the PR and comment on what is needed for it work.
Ran some tests locally - still working on it..

UPDATE:
There are deps I can't fix, mainly because opine imports stuff, which Deno 2.0 can't process anymore. Even if this is fixed, probably other stuff won't work. Since opine also is not maintained anymore, I will probably create a seperate repository with this as source, where I will have it fixed with hard deps I modify..

Todo

  • fix error: Import assertions are deprecated. Use with keyword, instead of 'assert' keyword. probably in superagent or express import, which imports 'mime-db'
    error get thrown in:
import db from "https://raw.githubusercontent.com/jshttp/mime-db/v1.52.0/db.json" assert { type: "json" };
 at https://deno.land/x/[email protected]/mod.ts:32:1

UPDATE: oak seems to be the trouble maker..
UPDATE: it's not oak - it's opine which is not maintained anymore - however please consider to remove or alter the deprecated https://deno.land/x/[email protected]/mod.ts. Maybe use import * as mod from "https://deno.land/[email protected]/media_types/mod.ts";

  • fix testing Readme.md examples
@dxdye dxdye mentioned this issue Nov 10, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant