9.1.1 - Fix Potential Internal Inconsistency #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 23, 2022 17:53
- Fixes a potential Internal Inconsistency Exception within the Scan History Controller - Since the data source is getting updated potentially on a different thread than the controller's insert call, it is possible that the data source and the pending update get out of sync ahead of the update
jbrophy17
force-pushed
the
out-of-bounds-exception
branch
from
01d26ab
to
eb4b975
Compare
litso
approved these changes
May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
History Controller
thread than the controller's insert call, it is possible that the data
source and the pending update get out of sync ahead of the update
Feature Description
Fixes a rare crash in the Scan History Controller where the backing datasource was out of sync when calling
insertRowson the table viewWhat To Test?
Tough to test because the crash was so infrequent. Confirm that the Scan History controller is correctly showing scans and that rapid scans don't cause any crashes