Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase scanner timeout; remove guaranteed length #25

Merged
merged 1 commit into from
Jul 20, 2018
Merged

Increase scanner timeout; remove guaranteed length #25

merged 1 commit into from
Jul 20, 2018

Conversation

u2606
Copy link
Contributor

@u2606 u2606 commented Jul 20, 2018

  • Increases the scan-to-continue timeout from 30 seconds to 45 seconds
  • Removes the readme’s guarantee that the timeout is 30 seconds (“after 30 seconds without a scan” → “after a short period of time without a scan”)

Pivotal Tickets

Update the scan-to-truck scanner timeout to 45 seconds

Increase scanner timeout; remove guaranteed length
a4a5855 
- Increases the scan-to-continue timeout from 30 seconds to 45 seconds
- Removes the readme’s guarantee that the timeout is 30 seconds
@u2606 u2606 requested a review from SeanMachen845 July 20, 2018 17:59
SeanMachen845
SeanMachen845 approved these changes Jul 20, 2018
View reviewed changes
Copy link
Contributor

@SeanMachen845 SeanMachen845 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕒⬆️

@u2606 u2606 merged commit 01744ff into master Jul 20, 2018
@u2606 u2606 deleted the increase-timeout branch July 20, 2018 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeanMachen845 SeanMachen845 SeanMachen845 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@u2606 @SeanMachen845