Do not try to set TTY mode if not a TTY

Author: clue

src/Stdin.php

@@ -14,39 +14,37 @@ class Stdin extends Stream
     public function __construct(LoopInterface $loop)
     {
         parent::__construct(STDIN, $loop);
-    }
 
-    public function resume()
-    {
-        if ($this->oldMode === null) {
+        if ($this->isTty()) {
             $this->oldMode = shell_exec('stty -g');
 
             // Disable icanon (so we can fread each keypress) and echo (we'll do echoing here instead)
             shell_exec('stty -icanon -echo');
-
-            parent::resume();
         }
     }
 
-    public function pause()
+    public function close()
     {
-        if ($this->oldMode !== null) {
-            // Reset stty so it behaves normally again
-            shell_exec(sprintf('stty %s', $this->oldMode));
+        $this->restore();
+        parent::close();
+    }
 
-            $this->oldMode = null;
-            parent::pause();
-        }
+    public function __destruct()
+    {
+        $this->restore();
     }
 
-    public function close()
+    private function restore()
     {
-        $this->pause();
-        parent::close();
+        if ($this->oldMode !== null && $this->isTty()) {
+            // Reset stty so it behaves normally again
+            shell_exec(sprintf('stty %s', $this->oldMode));
+            $this->oldMode = null;
+        }
     }
 
-    public function __destruct()
+    private function isTty()
     {
-        $this->pause();
+        return (is_resource(STDIN) && function_exists('posix_isatty') && posix_isatty(STDIN));
     }
 }

tests/FunctionalExampleTest.php

@@ -0,0 +1,39 @@
+<?php
+
+class FunctionalExampleTest extends TestCase
+{
+    public function testPeriodicExampleWithPipedInputEndsBecauseInputEnds()
+    {
+        $output = $this->execExample('echo hello | php 01-periodic.php');
+
+        $this->assertContains('you just said: hello\n', $output);
+    }
+
+    public function testPeriodicExampleWithNullInputQuitsImmediately()
+    {
+        $output = $this->execExample('php 01-periodic.php < /dev/null');
+
+        $this->assertNotContains('you just said:', $output);
+    }
+
+    public function testPeriodicExampleWithNoInputQuitsImmediately()
+    {
+        $output = $this->execExample('true | php 01-periodic.php');
+
+        $this->assertNotContains('you just said:', $output);
+    }
+
+    public function testPeriodicExampleWithSleepNoInputQuitsOnEnd()
+    {
+        $output = $this->execExample('sleep 0.1 | php 01-periodic.php');
+
+        $this->assertNotContains('you just said:', $output);
+    }
+
+    private function execExample($command)
+    {
+        chdir(__DIR__ . '/../examples/');
+
+        return shell_exec($command);
+    }
+}