-
-
Notifications
You must be signed in to change notification settings - Fork 38
Obey explicitly set HTTP protocol version for outgoing requests #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Obey explicitly set HTTP protocol version for outgoing requests #58
Conversation
|
Thanks for your PR! 👍 Can you add a test to confirm this actually works? The reason I'm asking is, this lib also works on PHP 5.3 which has to use http-client v0.3, which does not support this argument. I'm fine with this, but we should test and document this accordingly. |
|
Yes I just did, after looking at |
|
Took longer then expected but fixed the tests to work for both |
|
Thanks for the update! 👍 Just to make this more obvious, can you add a functional test case (against httpbin), also to document the default behavior? |
|
Sure thing, I'll research and add that 👍 |
|
There doesn't seem to be a way to get the HTTP version from HTTPBin, but since it's opensource and on github I'll give it a go adding that. |
Duh, my bad! If you're going to add this to HTTPBin, this would be super-awesome! Otherwise, I'm fine with ditching my request and would accept just adding some documentation for this in the meantime 👍 |
Lets see what the fine people at httpbin have to say about this first: postmanlabs/httpbin#305 😉 |
|
Seems postmanlabs/httpbin#305 is taking longer then hope/expected. I'll add code documentation, do you want anything in the readme as well? |
|
Too bad, but I guess just documentation is just fine for now 👍 Just describe the default behavior and how (and when) this can be changed and then let's get this in |
|
Will do, I already have the unit tests adapted but not committed yet. So once this PR is merged, I'll file a new one after with the updated tests. |
|
Added a note about it. Not sure if this is the right place, it was the best I could find though. |
|
Thanks, let's get this in! 👍 |
|
🎉 ! |
|
See also #59 which builds on top of this and reverts the default protocol version back to HTTP/1.0. |
|
Good catch, because this PR would technically introduce a BC |
Currently the request is lacking the HTTP version from the PSR-7 request. This PR adds that to the request