Add '<>' as not equal to in where clause

filhodanuvem · Nov 1, 2017 · f0d7b3b · f0d7b3b
1 parent 21e7a8a
commit f0d7b3b
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/lexical/lexical.go b/lexical/lexical.go
@@ -142,6 +142,9 @@ func Token() (uint8, *TokenError) {
 			if lexeme == "=" {
 				state = S_SMALLER_OR_EQUAL
 				break
+			} else if lexeme == ">" {
+				char = nextChar()
+				return T_NOT_EQUAL, nil
 			}
 			return T_SMALLER, nil
 		case S_SMALLER_OR_EQUAL:

diff --git a/runtime/commits_test.go b/runtime/commits_test.go
@@ -84,13 +84,23 @@ func TestSelectedFieldsCount(t *testing.T) {
 	}
 }
 
+func TestNotEqualsInWhereLTGT(t *testing.T) {
+	queryData := "select committer, hash from commits limit 1"
+	table := getTableForQuery(queryData, "../", t)
+	firstCommitter := table.rows[0]["committer"].(string)
+	query := fmt.Sprintf("select committer, hash from commits where committer <> '%s' limit 1", firstCommitter)
+	table = getTableForQuery(query, "../", t)
+	if firstCommitter == table.rows[0]["committer"].(string) {
+		t.Errorf("Still got the same committer as the first one. - %s", firstCommitter)
+	}
+}
 func TestNotEqualsInWhere(t *testing.T) {
 	queryData := "select committer, hash from commits limit 1"
 	table := getTableForQuery(queryData, "../", t)
 	firstCommitter := table.rows[0]["committer"].(string)
 	query := fmt.Sprintf("select committer, hash from commits where committer != '%s' limit 1", firstCommitter)
 	table = getTableForQuery(query, "../", t)
 	if firstCommitter == table.rows[0]["committer"].(string) {
-		t.Errorf("Strill got the same committer as the first one. - %s", firstCommitter)
+		t.Errorf("Still got the same committer as the first one. - %s", firstCommitter)
 	}
 }