Skip to content

fix: Prevent empty table from flickering #542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 2, 2022
Merged

Conversation

abdhalees
Copy link
Member

Description

  • Add missing dependancies to useLayoutEffect
  • Remove code that was specific for angular

Related links, issue #, if available: AWSUI-19844

How has this been tested?

Reproduced the bug manually and tested locally after the fix. to reproduce the bug:

  1. Go to table demo (classic theme)
  2. Ensure that no horizontal scrollbar is present on the table (determined at page load time)
  3. Use the text filter to reach the empty state
  4. Resize the browser window vertically to a smaller size until the table starts to jump
  5. make sure you have scrollbars are always enabled in mac settings
Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@abdhalees abdhalees requested a review from a team as a code owner December 1, 2022 09:52
@abdhalees abdhalees requested review from rubencarvalho and removed request for a team December 1, 2022 09:52
@codecov
Copy link

codecov bot commented Dec 1, 2022

Codecov Report

Base: 92.39% // Head: 92.38% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (cc4a500) compared to base (abd801c).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #542      +/-   ##
==========================================
- Coverage   92.39%   92.38%   -0.01%     
==========================================
  Files         569      569              
  Lines       16215    16214       -1     
  Branches     4432     4432              
==========================================
- Hits        14982    14980       -2     
- Misses       1149     1150       +1     
  Partials       84       84              
Impacted Files Coverage Δ
src/table/use-sticky-header.ts 82.92% <ø> (-2.79%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@abdhalees abdhalees merged commit 3349cc8 into main Dec 2, 2022
@abdhalees abdhalees deleted the empty-table-flickering branch December 2, 2022 14:59
abdhalees added a commit that referenced this pull request Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants