Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix code editor becoming hidden when the group is focused #3174

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

avinashbot
Copy link
Member

@avinashbot avinashbot commented Jan 8, 2025

Description

I don't think it's supposed to do that:

Screenshot 2025-01-08 at 16 27 55

Not sure when it happened, but we are colliding with ace's wrapper div for styling here. I assume the intent was always to have position: absolute, but I don't know if it ever worked with the mixin's position: relative overriding that anyway. So I moved those declarations to after the mixin.

Related links, issue #, if available: AWSUI-60262

How has this been tested?

Local testing, but I suppose a screenshot test is in order.

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@avinashbot avinashbot marked this pull request as ready for review January 8, 2025 15:40
@avinashbot avinashbot requested a review from a team as a code owner January 8, 2025 15:40
@avinashbot avinashbot requested review from orangevolon and removed request for a team January 8, 2025 15:40
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.40%. Comparing base (1c32dd6) to head (cbdd42a).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #3174    +/-   ##
========================================
  Coverage   96.40%   96.40%            
========================================
  Files         784      784            
  Lines       22143    22143            
  Branches     7604     7192   -412     
========================================
  Hits        21348    21348            
- Misses        743      788    +45     
+ Partials       52        7    -45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@avinashbot avinashbot added this pull request to the merge queue Jan 9, 2025
Merged via the queue into main with commit 1f1d269 Jan 9, 2025
42 checks passed
@avinashbot avinashbot deleted the fix-code-editor-focus branch January 9, 2025 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants