Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add more css specificity to center text in full width button dropdown main action #3164

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

abdhalees
Copy link
Member

Description

In ButtonDropdown component with main action and full width props, the css style to align text to the center gets overriden sometimes by Button component default styles due to not having enough specificity.

in this commit, passing fullWidth prop to internal button ensures that the text-align style is applied with a specificity that doesn't get overriden by default styles.

Related links, issue #, if available: n/a

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.40%. Comparing base (938e31b) to head (b1bb23d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #3164    +/-   ##
========================================
  Coverage   96.40%   96.40%            
========================================
  Files         784      784            
  Lines       22136    22136            
  Branches     7602     7190   -412     
========================================
  Hits        21341    21341            
- Misses        743      788    +45     
+ Partials       52        7    -45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abdhalees abdhalees enabled auto-merge January 2, 2025 14:00
@abdhalees abdhalees added this pull request to the merge queue Jan 2, 2025
Merged via the queue into main with commit 5fd71dd Jan 2, 2025
38 checks passed
@abdhalees abdhalees deleted the full-width-main-action-text-center branch January 2, 2025 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants