fix: Bottom padding in stacked table #3161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3161 +/- ##
========================================
Coverage 96.40% 96.40%
========================================
Files 784 784
Lines 22136 22138 +2
Branches 7602 7190 -412
========================================
+ Hits 21341 21343 +2
- Misses 743 788 +45
+ Partials 52 7 -45 ☔ View full report in Codecov by Sentry. |
pan-kot
previously approved these changes
Jan 2, 2025
| ); | ||
| }; | ||
|
|
||
| const ExampleTable = ({ variant }: { variant: 'container' | 'embedded' | 'borderless' | 'stacked' | 'full-page' }) => { |
There was a problem hiding this comment.
nit: I would either only use stacked or container or use TableProps.Variant here.
| sortingField: 'value', | ||
| }, | ||
| ]} | ||
| items={[ |
There was a problem hiding this comment.
nit: Would it be enough to use items from pages/table/generate-data and columns from pages/table/shared-configs?
pan-kot
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added bottom padding to stacked table. Previously when the last item was selected, there would be no space between the selected item and table border whereas container variant table had space.
Related links, issue #, if available: AWSUI-60100
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.