feat: Additional content slot in Collection Preferences #3124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3124 +/- ##
=======================================
Coverage 96.40% 96.40%
=======================================
Files 784 784
Lines 22136 22138 +2
Branches 7534 7592 +58
=======================================
+ Hits 21341 21343 +2
- Misses 743 788 +45
+ Partials 52 7 -45 ☔ View full report in Codecov by Sentry. |
| @@ -55,6 +55,10 @@ class PreferencesModalWrapper extends ModalWrapper { | |||
| findCustomPreference(): ElementWrapper | null { | |||
| return this.findByClassName(styles.custom); | |||
| } | |||
|
|
|||
| findAdditionalContent(): ElementWrapper | null { | |||
| return this.findByClassName(styles.additionalContent); | |||
There was a problem hiding this comment.
Suggested change
| return this.findByClassName(styles.additionalContent); | |
| return this.findByClassName(styles['additional-content']); |
src/collection-preferences/index.tsx
Outdated
| @@ -181,6 +182,10 @@ export default function CollectionPreferences({ | |||
| size={hasContentOnTheLeft && hasContentOnTheRight ? 'large' : 'medium'} | |||
| onDismiss={onCancelListener} | |||
| > | |||
| {/* Additional content */} | |||
| <div className={styles.additionalContent}>{additionalContent}</div> | |||
There was a problem hiding this comment.
Suggested change
| <div className={styles.additionalContent}>{additionalContent}</div> | |
| <div className={styles['additional-content']}>{additionalContent}</div> |
gethinwebster
approved these changes
Jan 3, 2025
gethinwebster
had a problem deploying
to
dev-pages
GitHub Actions
Failure
Merged
via the queue into
cloudscape-design:main
with commit Jan 3, 2025
e66864b
36 of 38 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a slot to the top of the modal content for Collection Preferences, this allows user to show additional info such as preference storage details and alerts if necessary.
Related links: https://quip-amazon.com/yAJ6ACqcFlIK/Collection-Preferences-Storage-method-display-Tech-design
How has this been tested?
Manually tested and added unit tests
When running the changes in the test pages for collection preferences (simple-page) the last collection preference component will have a test alert in the modal content
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.