Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support theming border width and button font weight. #3020

Merged
merged 11 commits into from
Nov 19, 2024

Conversation

DaemonCahill
Copy link
Member

@DaemonCahill DaemonCahill commented Nov 15, 2024

This PR adds support for theming field components border width and button font weight.

@DaemonCahill DaemonCahill requested a review from a team as a code owner November 15, 2024 20:20
@DaemonCahill DaemonCahill requested review from gethinwebster and jkuelz and removed request for a team November 15, 2024 20:20
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.32%. Comparing base (dc7000b) to head (873e824).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #3020    +/-   ##
========================================
  Coverage   96.32%   96.32%            
========================================
  Files         778      778            
  Lines       21888    21888            
  Branches     7079     7480   +401     
========================================
  Hits        21083    21083            
  Misses        797      797            
  Partials        8        8            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@jkuelz
Copy link
Member

jkuelz commented Nov 15, 2024

You need to regenerate the design token and theming snapshots to make the tests pass, run the following:
npx jest -u -c jest.integ.config.js src/__integ__/themes.test.ts
npx jest -u -c jest.unit.config.js src/__tests__/snapshot-tests/design-tokens.test.ts

src/popover/arrow.scss Outdated Show resolved Hide resolved
style-dictionary/visual-refresh/metadata/borders.ts Outdated Show resolved Hide resolved
gethinwebster
gethinwebster previously approved these changes Nov 18, 2024
src/internal/styles/forms/mixins.scss Show resolved Hide resolved
src/popover/arrow.scss Outdated Show resolved Hide resolved
src/select/parts/styles.scss Show resolved Hide resolved
jkuelz
jkuelz previously approved these changes Nov 18, 2024
jkuelz
jkuelz previously approved these changes Nov 18, 2024
Copy link
Member

@gethinwebster gethinwebster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for re-review, took a look at this again with more of a focus on "we're making more tokens themable" and what the possible unexpected impacts of that are, and I think there are important things that I missed first time round.

(in a nutshell, right now I think theming font-weight-button: normal would have unexpected side-effects, including introducing some potentially serious accessibility concerns)

src/anchor-navigation/styles.scss Outdated Show resolved Hide resolved
src/flashbar/styles.scss Show resolved Hide resolved
src/flashbar/collapsible.scss Show resolved Hide resolved
src/link/constants.scss Outdated Show resolved Hide resolved
src/link/constants.scss Outdated Show resolved Hide resolved
src/internal/styles/typography/mixins.scss Show resolved Hide resolved
@DaemonCahill DaemonCahill added this pull request to the merge queue Nov 19, 2024
Merged via the queue into main with commit e482c96 Nov 19, 2024
38 checks passed
@DaemonCahill DaemonCahill deleted the scottob-q-tokens branch November 19, 2024 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants