-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support theming border width and button font weight. #3020
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3020 +/- ##
========================================
Coverage 96.32% 96.32%
========================================
Files 778 778
Lines 21888 21888
Branches 7079 7480 +401
========================================
Hits 21083 21083
Misses 797 797
Partials 8 8 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
You need to regenerate the design token and theming snapshots to make the tests pass, run the following: |
ec09263
to
7401ceb
Compare
ee1063c
to
ac6b347
Compare
ac6b347
to
a5625a1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for re-review, took a look at this again with more of a focus on "we're making more tokens themable" and what the possible unexpected impacts of that are, and I think there are important things that I missed first time round.
(in a nutshell, right now I think theming font-weight-button: normal
would have unexpected side-effects, including introducing some potentially serious accessibility concerns)
a61939b
to
873e824
Compare
This PR adds support for theming field components border width and button font weight.