fix: Format date localized #3003
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3003 +/- ##
=======================================
Coverage 96.30% 96.30%
=======================================
Files 771 777 +6
Lines 21820 21877 +57
Branches 7450 7480 +30
=======================================
+ Hits 21013 21069 +56
+ Misses 799 755 -44
- Partials 8 53 +45 ☔ View full report in Codecov by Sentry. |
| // Store original timezone offset method | ||
| const originalTimezoneOffset = Date.prototype.getTimezoneOffset; | ||
|
|
||
| // Mock to simulate Pacific Time (UTC-8/UTC-7) |
There was a problem hiding this comment.
as an alternative, it could be achieved via using https://www.npmjs.com/package/timezone-mock lib
georgylobko
requested review from
abdhalees and
jperals
and removed request for
a team and
abdhalees
| @@ -0,0 +1,36 @@ | |||
| // Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | |||
There was a problem hiding this comment.
I ran this test locally without the changes in format-date-localized and it also passed.
There was a problem hiding this comment.
oh right, because I reproduced this problem locally after changing my system timezone to pacific
There was a problem hiding this comment.
I rewrote this as an integration test because the only way to test it in a unit test environment would be to set up a separate environment with a global timezone. Moreover, the integration test I added now fully covers the original bug scenario.
Description
This PR addresses the problem described in the ticket AWSUI-59971 when the date that includes a negative timezone in relation to UTC is parsed incorrectly.
Related links, issue #, if available: n/a
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.