Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use column layout in items palette #331

Merged
merged 1 commit into from
Dec 7, 2024

Conversation

pan-kot
Copy link
Member

@pan-kot pan-kot commented Nov 25, 2024

Description

Introduces column layout to board items palette to fit more items when there is enough horizontal space in both side and bottom orientations of the panel.

Rel: [4xTcAv3PK6h2]

How has this been tested?

  • Manual testing in test pages and demos
Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.99%. Comparing base (4a5fb2a) to head (3449e46).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #331      +/-   ##
==========================================
+ Coverage   93.94%   93.99%   +0.04%     
==========================================
  Files          61       61              
  Lines        4312     4312              
  Branches      740      528     -212     
==========================================
+ Hits         4051     4053       +2     
+ Misses        261      259       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pan-kot pan-kot marked this pull request as ready for review December 6, 2024 06:11
@pan-kot pan-kot requested a review from a team as a code owner December 6, 2024 06:11
@pan-kot pan-kot requested review from gethinwebster and removed request for a team December 6, 2024 06:11
@pan-kot pan-kot added this pull request to the merge queue Dec 7, 2024
Merged via the queue into main with commit ea5364e Dec 7, 2024
41 of 42 checks passed
@pan-kot pan-kot deleted the feat-column-layout-in-palette branch December 7, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants