fix: Ensure module field exists in all log messages #1941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erezrokah
commented
Oct 22, 2024
| @@ -134,6 +134,8 @@ func (s *PluginServe) newCmdPluginServe() *cobra.Command { | |||
| logger = log.Output(zerolog.ConsoleWriter{Out: os.Stdout}).Level(zerologLevel) | |||
| } | |||
|
|
|||
| logger = logger.With().Str("module", s.plugin.Name()+"-"+string(s.plugin.Kind())).Logger() | |||
There was a problem hiding this comment.
Not shown in the diff but we do s.plugin.SetLogger(logger) a bit below
disq
approved these changes
Oct 22, 2024
erezrokah
requested review from
marianogappa
and removed request for
dcelasun
marianogappa
approved these changes
Oct 22, 2024
kodiakhq bot
pushed a commit
that referenced
this pull request
Oct 22, 2024
🤖 I have created a release *beep* *boop* --- ## [4.67.1](v4.67.0...v4.67.1) (2024-10-22) ### Bug Fixes * **deps:** Update module github.com/aws/aws-sdk-go-v2/config to v1.28.0 ([#1940](#1940)) ([35cf587](35cf587)) * **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.24.1 ([#1943](#1943)) ([14f44ad](14f44ad)) * Ensure module field exists in all log messages ([#1941](#1941)) ([b1ca41c](b1ca41c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes https://github.com/cloudquery/cloudquery-issues/issues/2627
The wrong value in the
modulefield is because of the bug fixed in cloudquery/plugin-pb-go#421Use the following steps to ensure your PR is ready to be reviewed
go fmtto format your code 🖊golangci-lint run🚨 (install golangci-lint here)