feat: Add duration_ms to table sync finished log message
#1757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erezrokah
commented
Jun 20, 2024
erezrokah
requested review from
a team and
candiduslynx
and removed request for
hermanschaaf,
yevgenypats and
a team
candiduslynx
approved these changes
Jun 21, 2024
kodiakhq bot
pushed a commit
that referenced
this pull request
Jun 21, 2024
🤖 I have created a release *beep* *boop* --- ## [4.47.0](v4.46.1...v4.47.0) (2024-06-21) ### Features * Add `duration_ms` to `table sync finished` log message ([#1757](#1757)) ([9ea034d](9ea034d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
5 tasks
kodiakhq bot
pushed a commit
that referenced
this pull request
Jun 21, 2024
#### Summary Follow up to #1757, as it seems we're accessing table metrics in other Go routines (e.g. `resolveResource`) ---
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of https://github.com/cloudquery/cloudquery-issues/issues/1778 (internal issue). Adds the duration in milliseconds to the table finished log message.
Tested this with open telemetry data that we send and the values match
Use the following steps to ensure your PR is ready to be reviewed
go fmtto format your code 🖊golangci-lint run🚨 (install golangci-lint here)