fix: Allow marshaling plain string values into JSON scalars #1743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
candiduslynx
requested review from
yevgenypats,
hermanschaaf and
erezrokah
as code owners
disq
approved these changes
Jun 19, 2024
hermanschaaf
approved these changes
Jun 19, 2024
kodiakhq bot
pushed a commit
that referenced
this pull request
Jun 19, 2024
🤖 I have created a release *beep* *boop* --- ## [4.45.3](v4.45.2...v4.45.3) (2024-06-19) ### Bug Fixes * Allow marshaling plain string values into JSON scalars ([#1743](#1743)) ([87e90b8](87e90b8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
|
Isn't a plain string not a valid JSON? Only a quoted one is a valid JSON? |
yes (as we check |
erezrokah
reviewed
Jun 19, 2024
| @@ -15,6 +21,7 @@ func TestJSONSet(t *testing.T) { | |||
| {source: "{}", result: JSON{Value: []byte("{}"), Valid: true}}, | |||
| {source: `"test"`, result: JSON{Value: []byte(`"test"`), Valid: true}}, | |||
| {source: "1", result: JSON{Value: []byte("1"), Valid: true}}, | |||
| {source: `json some data`, result: JSON{Value: []byte(`"json some data"`), Valid: true}}, | |||
There was a problem hiding this comment.
The source value is an unquoted string so not sure why we're treating it as a valid JSON
But this PR makes it so that any unquoted string value is treated as a valid JSON no? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/cloudquery/cloudquery-issues/issues/1875