fix: Remove no sentry deprecation warning #1740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
disq
approved these changes
Jun 17, 2024
kodiakhq bot
pushed a commit
that referenced
this pull request
Jun 17, 2024
🤖 I have created a release *beep* *boop* --- ## [4.45.2](v4.45.1...v4.45.2) (2024-06-17) ### Bug Fixes * **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.20.1 ([#1739](#1739)) ([cdb1b6b](cdb1b6b)) * **deps:** Update module google.golang.org/protobuf to v1.34.2 ([#1737](#1737)) ([ced9333](ced9333)) * Remove no sentry deprecation warning ([#1740](#1740)) ([1fb06bc](1fb06bc)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If you try to disable telemetry with plugins using the latest SDK you get this warning:
The reason is that the CLI still sends this flag (ends up here https://github.com/cloudquery/plugin-pb-go/blob/aeb0d17fd2577caacbfdadfecc89fa4a1357cca6/managedplugin/plugin.go#L448), so new plugins print a warning.
We can't remove the sending of the flag, since then older plugins will start sending sentry errors 🙃
I suggest we remove the log warning for now, and give users a bit of time to upgrade plugins, then remove the flag altogether
Use the following steps to ensure your PR is ready to be reviewed
go fmtto format your code 🖊golangci-lint run🚨 (install golangci-lint here)