Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't include other relation siblings if not specified in config #1720

Merged
merged 3 commits into from
Jun 14, 2024

Conversation

erezrokah
Copy link
Member

@erezrokah erezrokah commented Jun 5, 2024

Summary

Fixes cloudquery/cloudquery#18206

  • Read the contribution guidelines πŸ§‘β€πŸŽ“
  • Run go fmt to format your code πŸ–Š
  • Lint your changes via golangci-lint run 🚨 (install golangci-lint here)
  • Update or add tests πŸ§ͺ
  • Ensure the status checks below are successful βœ…

@github-actions github-actions bot added the test label Jun 5, 2024
@erezrokah erezrokah changed the title test: Add failing test fix: Don't include other relations if not specified in config Jun 5, 2024
@github-actions github-actions bot added fix and removed test labels Jun 5, 2024
@erezrokah erezrokah marked this pull request as ready for review June 5, 2024 16:42
@erezrokah erezrokah changed the title fix: Don't include other relations if not specified in config fix: Don't include other relation siblings if not specified in config Jun 5, 2024
@github-actions github-actions bot added fix and removed fix labels Jun 5, 2024
Copy link

github-actions bot commented Jun 5, 2024

⏱️ Benchmark results

Comparing with f2e1766

  • Glob-8 ns/op: 91.81 ⬆️ 0.69% increase vs. f2e1766

@kodiakhq kodiakhq bot merged commit f730ec5 into cloudquery:main Jun 14, 2024
7 checks passed
kodiakhq bot pushed a commit that referenced this pull request Jun 14, 2024
πŸ€– I have created a release *beep* *boop*
---


## [4.45.0](v4.44.2...v4.45.0) (2024-06-14)


### Features

* Remove plugin option for logging error events to Sentry ([#1724](#1724)) ([7732fe8](7732fe8))


### Bug Fixes

* **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.19.19 ([#1726](#1726)) ([a1dd044](a1dd044))
* Don't include other relation siblings if not specified in config ([#1720](#1720)) ([f730ec5](f730ec5))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Referencing a single relation table might include other non related relation tables
3 participants