Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add records_default_proxied variable #48

Closed
wants to merge 6 commits into from
Closed

Add records_default_proxied variable #48

wants to merge 6 commits into from

Conversation

glensc
Copy link
Contributor

@glensc glensc commented Aug 22, 2024 •
edited
Loading

references

Fixes #47

NOTE: df34716 fixes version pins added in 9141c9a commit.

@mergify mergify bot added the triage Needs triage label Aug 22, 2024
@glensc glensc marked this pull request as ready for review August 22, 2024 20:35
@glensc glensc requested review from a team as code owners August 22, 2024 20:35
@glensc glensc requested review from Gowiem and joe-niland August 22, 2024 20:35
@mergify Mergify
Copy link

mergify bot commented Aug 23, 2024

💥 This pull request now has conflicts. Could you fix it @glensc? 🙏

@mergify mergify bot added the conflict This PR has conflicts label Aug 23, 2024
@glensc glensc mentioned this pull request Aug 26, 2024
Merged
@mergify mergify bot removed the conflict This PR has conflicts label Aug 26, 2024
@mergify Mergify
Copy link

mergify bot commented Sep 19, 2024

💥 This pull request now has conflicts. Could you fix it @glensc? 🙏

@mergify mergify bot added the conflict This PR has conflicts label Sep 19, 2024
@glensc
Copy link
Contributor Author

glensc commented Sep 22, 2024

no point resolving conflicts if this isn't going to be accepted. so far nobody as reviewed this

@mergify mergify bot closed this Sep 26, 2024
@mergify Mergify
Copy link

mergify bot commented Sep 26, 2024

This PR was closed due to inactivity and merge conflicts. 😭
Please resolve the conflicts and reopen if necessary.

@mergify mergify bot removed conflict This PR has conflicts triage Needs triage labels Sep 26, 2024
@glensc
Copy link
Contributor Author

glensc commented Sep 29, 2024

well. nobody reviewed the code, what's the point of putting more work if nobody accepts this?

@glensc
Copy link
Contributor Author

glensc commented Sep 29, 2024

@osterman

@glensc
Copy link
Contributor Author

glensc commented Nov 14, 2024

@goruha

@glensc glensc mentioned this pull request Nov 14, 2024
Open
@nitrocode
Copy link
Member

One of the best ways to get visibility is to join the slack channel called #pr-reviews in the sweetops community slack

nitrocode
nitrocode reviewed Nov 14, 2024
View reviewed changes
main.tf
@@ -10,6 +10,7 @@ locals {
for index, record in var.records :
try(record.key, format("%s-%s-%s", record.name, record.type, record.value)) => record
} : {}
records_default_proxied = var.records_default_proxied
Copy link
Member

@nitrocode nitrocode Nov 14, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This local isn't providing much value. You can use the var directly below instead

Suggested change
records_default_proxied = var.records_default_proxied

nitrocode
nitrocode reviewed Nov 14, 2024
View reviewed changes
main.tf
@@ -40,7 +41,7 @@ resource "cloudflare_record" "default" {
value = each.value.value
comment = lookup(each.value, "comment", null)
priority = lookup(each.value, "priority", null)
proxied = lookup(each.value, "proxied", false)
proxied = lookup(each.value, "proxied", local.records_default_proxied)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
proxied = lookup(each.value, "proxied", local.records_default_proxied)
proxied = lookup(each.value, "proxied", var.records_default_proxied)

@glensc
Copy link
Contributor Author

glensc commented Dec 12, 2024 •
edited
Loading

I can't reopen the pr, not enough permissions. need to be project developer?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitrocode nitrocode nitrocode left review comments

@Gowiem Gowiem Awaiting requested review from Gowiem Gowiem is a code owner automatically assigned from cloudposse/contributors

@joe-niland joe-niland Awaiting requested review from joe-niland joe-niland is a code owner automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change records "proxied" default
2 participants
@glensc @nitrocode