From 2c6b476929b660445cdeb5c760a417c404d780d6 Mon Sep 17 00:00:00 2001
From: Veronika Gnilitska <30597968+gberenice@users.noreply.github.com>
Date: Thu, 11 Jul 2024 14:57:21 +0300
Subject: [PATCH] fix: add an attribute to examples/completed to avoid name
conflict in test concurrent runs (#60)
* chore: bump terraform-aws-modules/notify-slack/aws module version to 6.4.0
* fix: add attribute to support concurrent runs
* fix: bump tf version constraint
---
README.md | 4 ++--
docs/terraform.md | 4 ++--
examples/complete/main.tf | 4 ++++
examples/complete/versions.tf | 2 +-
main.tf | 2 +-
versions.tf | 2 +-
6 files changed, 11 insertions(+), 7 deletions(-)
diff --git a/README.md b/README.md
index df1c2e5..c4c2001 100644
--- a/README.md
+++ b/README.md
@@ -77,7 +77,7 @@ module "notify_slack" {
| Name | Version |
|------|---------|
-| [terraform](#requirement\_terraform) | >= 0.13.0 |
+| [terraform](#requirement\_terraform) | >= 1.0 |
| [archive](#requirement\_archive) | >=1.3 |
| [aws](#requirement\_aws) | >= 2.0 |
| [local](#requirement\_local) | >= 1.3 |
@@ -93,7 +93,7 @@ No providers.
| Name | Source | Version |
|------|--------|---------|
| [default\_label](#module\_default\_label) | cloudposse/label/null | 0.25.0 |
-| [notify\_slack](#module\_notify\_slack) | terraform-aws-modules/notify-slack/aws | 5.6 |
+| [notify\_slack](#module\_notify\_slack) | terraform-aws-modules/notify-slack/aws | 6.4.0 |
| [this](#module\_this) | cloudposse/label/null | 0.25.0 |
## Resources
diff --git a/docs/terraform.md b/docs/terraform.md
index 730a88d..d1f334f 100644
--- a/docs/terraform.md
+++ b/docs/terraform.md
@@ -3,7 +3,7 @@
| Name | Version |
|------|---------|
-| [terraform](#requirement\_terraform) | >= 0.13.0 |
+| [terraform](#requirement\_terraform) | >= 1.0 |
| [archive](#requirement\_archive) | >=1.3 |
| [aws](#requirement\_aws) | >= 2.0 |
| [local](#requirement\_local) | >= 1.3 |
@@ -19,7 +19,7 @@ No providers.
| Name | Source | Version |
|------|--------|---------|
| [default\_label](#module\_default\_label) | cloudposse/label/null | 0.25.0 |
-| [notify\_slack](#module\_notify\_slack) | terraform-aws-modules/notify-slack/aws | 5.6 |
+| [notify\_slack](#module\_notify\_slack) | terraform-aws-modules/notify-slack/aws | 6.4.0 |
| [this](#module\_this) | cloudposse/label/null | 0.25.0 |
## Resources
diff --git a/examples/complete/main.tf b/examples/complete/main.tf
index 6aec0bc..e184d23 100644
--- a/examples/complete/main.tf
+++ b/examples/complete/main.tf
@@ -9,4 +9,8 @@ module "notify_slack" {
slack_webhook_url = var.slack_webhook_url
slack_channel = var.slack_channel
slack_username = var.slack_username
+ # Add MD5 hash of a timestamp attribute to avoid conflict for concurrent test runs, e.g.:
+ # `Error: creating CloudWatch Logs Log Group (/aws/lambda/eg-test-sns-default):
+ # ResourceAlreadyExistsException: The specified log group already exists.`
+ attributes = [md5(timestamp())]
}
\ No newline at end of file
diff --git a/examples/complete/versions.tf b/examples/complete/versions.tf
index a7e765d..a6d306b 100644
--- a/examples/complete/versions.tf
+++ b/examples/complete/versions.tf
@@ -1,5 +1,5 @@
terraform {
- required_version = ">= 0.13.0"
+ required_version = ">= 1.0"
required_providers {
aws = {
diff --git a/main.tf b/main.tf
index 65aa8f6..8fb7f44 100644
--- a/main.tf
+++ b/main.tf
@@ -7,7 +7,7 @@ module "default_label" {
module "notify_slack" {
source = "terraform-aws-modules/notify-slack/aws"
- version = "5.6"
+ version = "6.4.0"
create = module.this.enabled
create_sns_topic = var.create_sns_topic
lambda_function_name = module.default_label.id
diff --git a/versions.tf b/versions.tf
index 5c1c572..5d253b6 100644
--- a/versions.tf
+++ b/versions.tf
@@ -1,5 +1,5 @@
terraform {
- required_version = ">= 0.13.0"
+ required_version = ">= 1.0"
required_providers {
aws = {