Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support sassc? #316

Closed
mattbrictson opened this issue Sep 11, 2018 · 5 comments
Closed

Support sassc? #316

mattbrictson opened this issue Sep 11, 2018 · 5 comments
Assignees
Labels

Comments

@mattbrictson
Copy link

I tried using the cloudinary gem together with sassc-rails and it looks like this combination is not currently supported.

The cloudinary gem expects sass-rails to be present in the Gemfile, so I applied this workaround:

# Gemfile
gem 'sass-rails', require: false
gem 'sassc-rails',

This allows Rails to boot, but then when I attempt to use the cloudinary_url function in one of my .scss files I get the following error:

SassC::SyntaxError
Error: Function cloudinary_url doesn't support keyword arguments

Do you have any suggestions for using sassc-rails together with cloudinary? The sassc gem is 4x faster than Ruby sass and is a must-have for larger projects. Ideally the cloudinary gem would support either sass or sassc out of the box, without workarounds or patches.

@shirlymanor
Copy link

I'm sorry for the late response!
It's on our road-map but no ETA yet.
We will update here when will have any insights.

@benkubic
Copy link

Any update on this? Rails 6 is coming soon and it will require sassc-rails by default, so the gem is blocking our upgrade path

@nicovak
Copy link

nicovak commented Sep 6, 2019

PR linked, I hope It will be fixed soon, rails 6 isn't fully compatible yet.

@GeoffTidey
Copy link

Looks like this is stopping our migration to rails 6

SassC::SyntaxError at /en
Error: Function cloudinary-url doesn't support keyword arguments
        on line 30:25 of app/assets/stylesheets/sharing.scss
        from line 27:9 of app/assets/stylesheets/application.scss
>>       background-image: cloudinary-url('icons/share-facebook.svg', $quality:
   ------------------------^

Any news on an ETA for a fix?

@shirlymanor
Copy link

We are actively working on a new version that will handle Rails6 sassc. The current ETA is the end of this month.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants