Skip to content
This repository has been archived by the owner on Oct 8, 2024. It is now read-only.

Configure globally #60

Closed
bytestream opened this issue Dec 17, 2019 · 5 comments
Closed

Configure globally #60

bytestream opened this issue Dec 17, 2019 · 5 comments

Comments

@bytestream
Copy link

It would be good if we could set global defaults for the configuration, particularly for localisation of Show/Hide

$.fn.hideShowPassword.defaults = {...}

I think it would just be a simple case of adding $.extend({}, $.fn.hideShowPassword.defaults, params) here https://github.com/cloudfour/hideShowPassword/blob/master/hideShowPassword.js#L198

@bytestream
Copy link
Author

@tylersticka happy to submit a PR if you agree

@tylersticka
Copy link
Member

@bytestream Sure, sounds good!

@bytestream
Copy link
Author

Sent :)

@tylersticka
Copy link
Member

@bytestream Your PR (#61) has been merged, and the change is now available in version 2.2.0 of this package. Thank you for your contribution!

@bytestream
Copy link
Author

Awesome! Thanks for the fast turnaround.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants