Skip to content

Add the sidecar rootfs path to the windows rep #993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 20, 2025
Merged

Add the sidecar rootfs path to the windows rep #993

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e2391ce
Add the sidecar rootfs path to the windows rep
ivo1116 Feb 19, 2025
14a104d
Fix linux spec description quotes
ivo1116 Feb 20, 2025
b95d38e
Fix windows spec description quotes
ivo1116 Feb 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion jobs/rep/spec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ properties:
diego.rep.preloaded_rootfses:
description: "Array of name:absolute_path pairs representing root filesystems preloaded onto the underlying garden"
diego.rep.sidecar_rootfs_path:
description: "absolute_path representing the root filesystem used for sidecar processes (ie. "/var/vcap/packages/cflinuxfs4/rootfs.tar"). Must be one of the preloaded_rootfses paths. Leaving the default empty string is ok, as it will then select the first of he preloaded_rootfses"
description: "absolute_path representing the root filesystem used for sidecar processes (ie. '/var/vcap/packages/cflinuxfs4/rootfs.tar'). Must be one of the preloaded_rootfses paths. Leaving the default empty string is ok, as it will then select the first of he preloaded_rootfses"
default: ""
diego.rep.rootfs_providers:
description: "Array of schemes for which the underlying garden can support arbitrary root filesystems"
Expand Down
3 changes: 3 additions & 0 deletions jobs/rep_windows/spec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,9 @@ properties:
description: "Array of name:absolute_path pairs representing root filesystems preloaded onto the underlying garden"
default:
- windows2012R2:/tmp/windows2012R2
diego.rep.sidecar_rootfs_path:
description: "absolute_path representing the root filesystem used for sidecar processes (ie. '/tmp/windows2012R2'). Must be one of the preloaded_rootfses paths. Leaving the default empty string is ok, as it will then select the first of he preloaded_rootfses"
default: ""
diego.rep.rootfs_providers:
description: "Array of schemes for which the underlying garden can support arbitrary root filesystems"
default: []
Expand Down
1 change: 1 addition & 0 deletions jobs/rep_windows/templates/rep.json.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@
placement_tags: p("diego.rep.placement_tags"),
polling_interval: "#{p("diego.rep.polling_interval_in_seconds")}s",
preloaded_root_fs: p("diego.rep.preloaded_rootfses"),
sidecar_root_fs_path: p("diego.rep.sidecar_rootfs_path"),
read_work_pool_size: p("diego.executor.read_work_pool_size"),
skip_cert_verify: p("diego.ssl.skip_cert_verify"),
supported_providers: p("diego.rep.rootfs_providers"),
Expand Down