Allow property overrides to configure etcd #99
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onfigures the other etcd properties.
|
Hey cholick! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you've already signed the CLA. |
1 similar comment
|
Hey cholick! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you've already signed the CLA. |
|
We have created an issue in Pivotal Tracker to manage this. You can view the current status of your issue at: https://www.pivotaltracker.com/story/show/107859694. |
Contributor
|
Thanks, @cholick! Are these overrides related to the consul datacenter override PR you also submitted? Best, |
Contributor
Author
|
They're related in that it was a set of changes to add enough flexibility to get the scripts to work with our installation, but the actual commit should be independent. Feel free to close this one if you don't want to take it, as we ended up scrapping one approach and of the three pull requests, this is the one change we didn't need for the final working manifest. (Though someone else might need it) |
Contributor
|
Thanks for the extra context, @cholick. If you won't currently find this change valuable, we'll go ahead and close this PR out. |
tas-runtime-bot
added a commit
that referenced
this pull request
Jul 17, 2024
tas-runtime-bot
added a commit
that referenced
this pull request
Aug 2, 2024
…vizzini garden grootfs idmapper Submodule src/code.cloudfoundry.org/auctioneer 84b15846c..127aac4 (rewind): < Struct changes due to new protobuf Submodule src/code.cloudfoundry.org/bbs dc5cde76c...096d0e1a7: > Increase start timeout for BBS tests (#99) < Remove debug log statements < Change interface{} to explicit type so we can use ToProto() and send to newTestRequest < We can use d.Routes directly here since it's a pointer < Replace eventfakes with new FakeEvent object < Make FakeEvent a proper proto object Regenerate protos > Remove nil check to satisfy staticcheck < Routable is a pointer and needs to be dereferenced < Need to store the deserializeModel result in a variable to use later < Change responses to use pointers so we can use them after the method calls < Lint ignore for unnecessary nil check Change routes to use pointers < Ginkgo unfocus + lint ignore for deprecated method testing < WIP: Make integration tests use new protobuf < Struct and naming convention changes; Trueing up lint deprecation < Regenerate protos with deprecated markers < Added support for deprecated things to be marked as such in the output files < Struct and naming changes due to new protobuf < Struct and naming changes due to new protobuf < Merge branch 'main' into protobuf-with-plugin < Naming convention change due to new protobuf < Updated loggregator to v9 < expectedEvent doesn't need to be converted to a Proto here < Add conversions for protobuf messages < Add ToEventProto for models.Event interface < Replace gogo protobuf with google protobuf < Use google.golang protobuf instead of gogo protobuf Remove Unmarshal from MessageValidator interface (use proto.Marshal instead) < Structure and naming changes due to Protobuf upgrades < Add Validate functions for Proto structs < Have to use Proto structs (.ToProto()) in proto.Marshal < Naming convention changes due to protobuf updates < Have to pass a Proto struct in order to populate correctly, then use FromProto for the return value < Naming convention changes due to protobuf updates < Remove usage of protojson, encoding/json package is enough for our use case < copy() is destination first < Regenerate protos with improved optional support and AlwaysEmit changes < Protos: Add AlwaysEmit options to Messages to match old protobuf results < Codegen: Handle optional fields better: Make sure we're checking for nils Set default values where appropriate When a Map has a value of Message type, dereference for Equal < Codegen: Action no longer needs special Get/SetValue in accessors < Codegen: alwaysEmit->jsonEmit < Add JsonAlwaysEmit and CustomType features; Regenerate protos for codegen < Redirect output from pushd/popd to /dev/null < WIP: What if Routes wasn't a special case? < Add explicit json_name for static and dynamic < Codegen: Remove extra log messages, use Desc.Name() for ignoredMessages < Update Task test for protobuf and protojson changes < Regenerate protos for json_name changes < Add json_names for fields with underscores < Update SecurityGroups test for protobuf and protojson changes < Regenerate protos for Action special case < Add special case for Action types (they need GetValue and SetValue) < Add ExcludeFromEqual to Error.Message; regenerate error.proto < Codegen: Add support for ExcludeFromEqual feature and regenerate codegen protos < Update tests to account for protojson and protobuf changes < Add GetProto for Actions so we can marshal/unmarshal correctly < Regenerate actions.proto for json_name changes < Add json_name tags to prevent camelCase from happening < Use protojson for Marshal/Unmarshal functionality < Update pointers to reflect new ByValue types < Regenerate protos with new ByValue types < Add ByValue attributes to match old protobuf declarations < Codegen: Don't generate a Getter for By Value types < Regenerate protos for nil checks on ProtoSlice/ProtoMap methods and bbs_by_value support < Pointer changes / Proto conversion for Routes bbs_by_value < Add nil checks on ToProto/FromProto Custom Routes type requires json.RawMessage but we only have []byte, so conversion has to be done manually < Make custom Routes type use bbs_by_value < Codegen: Add nil checks for ProtoSlice and ProtoMap methods < Codegen: Add support for bbs_by_value < Codegen: Regenerate bbs.proto for bbs_by_value support < Codegen: Add bbs_by_value option (allows fields to be passed by value instead of reference) < Use generate_protos script < Update generate_protos script to handle plugin < Regenerate protos with nil checks for ToProto and From Proto < CodeGen: add nil checks for ToProto and FromProto methods < Extract structs into variables and use ToProto to give back a proto.Message < Add ToEventProto to Event interface and use it for Un/Marshalling < Remove old gogoproto generated files < Use copy instead of loop (staticcheck compliance) < Test changes to reflect proto and model changes < Add FromProto to Routes special case < Regenerate protos with new Slice/Map methods and FromProto methods < Differentiate between Slices and Maps Add FromProto methods < Bring back old functionality after ignoring ProtoRoutes/Routes in our protoc plugin < Regenerate desired_lrp proto (ignore ProtoRoutes in favor of routes.go) < Handles Routes special case for Equal < Regenerate protos (was using RC release) Make bbs.pb.go a full file (try to resolve this later) < Revert package change and remove softlinks < Change package of protogen plugin to models and softlink .proto and .pb.go files into models Always ignore bbs.proto when generating our plugin's files < Weird Routes issue (assume because we aren't using the one defined in routes.go any more) < Standardization of enum value names (include containing struct) < Standardization of enum value names (include containing struct) < Lack of protobuf embed support requires using the structs directly < Pointer changes due to standard protobuf updates < Standardization of ActualLRP=>ActualLrp < Remove gogoproto proto.Message < Standardization of DesiredLRP=>DesiredLrp < Lack of protobuf embed support requires using the structs directly < Pointer changes due to standard protobuf updates < Regenerate protos for maps with a value type of protogen message < Fix type on enumvalue_customname < Don't need Proto prefix for string types < Add support for map values with a protogen'd message type Add ProtoMap function for conversion between our map and the default protogen map < Default value for repeated fields (arrays/slices) is nil < Use type name instead of field name when generating an enum cast < Pointer changes due to optional field support < Field name standardization on ActualLrp* < Pointer changes due to optional field support < Regenerate protos with standardized LRP fieldName modifications (i.e. no modifications from standard protoc output) < Remove getFieldName overrides for Actual/DesiredLRP. This wasn't consistent so we're going to standardize on the output from basic protoc (ActualLrp instead of ActualLRP) < Regenerate protos after ToProto field name fix < Incorrect field name used when generating ToProto function < Regenerate protos after oneof removal < Remove support for oneof since we weren't using it (previous use of oneof was incorrect and essentially a non-use of oneof) < Regenerate protos with optional field support < Add support for optional fields < Remove duplicate methods generated by plugin < Regenerate protos for Routable fix < These Routables aren't messages, so don't need the 'Proto' prefix < CellId exists on ActualLRPInstanceKey. Golang protobuf doesn't support embedded types, so we need to reference this directly. Potential NRE if ActualLRPInstanceKey is null, but this function doesn't look like it's being used. < Regenerate protos with getFieldName overrides for Actual/DesiredLRP < Add getFieldName func: For adding additional logic to generated field name (e.g. ActualLrp => ActualLRP) This is intended to be reverted after confirming bbs still works after the plugin is finished. It's here now because we want to make as few changes to the bbs code as possible. < Regenerate protos with Equal function < No longer ignoring ProtoRoutes < Add Equal function for struct generation < Regenerate protos with Enum String func < Add String function to enum generation Remove unnecessary check on len(msg.Enums) < Regenerate protos with enum name/value maps < Add name/value maps to enum generation < Remove duplicate methods generated by our protoc plugin < Remove duplicate methods generated by our protoc plugin < Remove duplicate methods generated by our protoc plugin < Remove gogoproto proto.Message from ActionInterface < Remove duplicate methods generated by our protoc plugin < Regenerate protos with accessors < Import bbs.proto for enum customname extension < Support generating accessors (Get/Set) Rearrange some code for scope changes < Regenerate protos with new plugin < Make use of enumvalue_customvalue extension Remove extra Proto for ProtoRoutes < Move bbs.proto to protoc plugin folder < Add new protoc plugin for bbs code generation < WIP: proto changes < WIP: New protoc plugin for BBS < Move gogoproto files to their own directory < Protos: Change oneof optionals to actual optionals (oneofs weren't being used correctly) < Protos: omitempty no longer needed (protobuf always adds it) < Protos: Change option go_package to code.cloudfoundry.org/bbs/models < Protos: Move optional to beginning of line Remove json_name definitions where not needed < Protos: Remove gogoproto.equal_all < Protos: Remove string_name from enums (does not work) < Protos: Remove gogoproto.goproto_enum_prefix_all < Protos: gogoproto.enumvalue_customname => string_name < Protos: Remove gogoproto.customtype < Protos: Remove gogoproto.embed < Protos: Remove gogoproto.nullable false (required fields are not valid in protobuf3) < Protos: gogoproto.nullable true => optional < Protos: gogoproto.jsontag => json_name < Protos: Add option go_package < Protos: Remove import of gogoproto < Preserve gogoproto generated files Submodule src/code.cloudfoundry.org/cfdot e6e5eb7b7..864c4a6 (rewind): < Update to use new protobufs Submodule src/code.cloudfoundry.org/diego-ssh 48f3aed47..ddb0135 (rewind): < Update to use the latest protobufs Submodule src/code.cloudfoundry.org/executor 4cacd8fff...0a01dbec4: < Merge main into protobuf-with-plugin > Fix failing test after removing replace directive for gomega < Change Should.Receive(nil) to ShouldNot(Receive()) since Gomega requires a pointer and this should be equivalent < Resolve staticcheck issues with Errorf and testing deprecated functionality < SetNofile and SetNproc take pointers now due to protobuf changes Submodule src/code.cloudfoundry.org/inigo bbfc4e6ee..563aea6 (rewind): < Update struct references to match new protobufs Submodule src/code.cloudfoundry.org/rep 10ddcf1ec...f77ddfc4f: < Protobuf change after merge < Merge main into protobuf-with-plugin > Fix failing tests with replace directive removed for gomega < Change Should.Receive(nil) to ShouldNot(Receive()) since Gomega requires a pointer and this should be equivalent < Struct changes due to new protobuf Submodule src/code.cloudfoundry.org/route-emitter 0cb4c6d48..a43b37c (rewind): < Instances has to be set explicitly to 0 since it's a pointer now < Update to use new protobufs Submodule src/code.cloudfoundry.org/vizzini 626135a82..56193ba (rewind): < Update struct references to match new protobufs Submodule src/garden e508adf1e..680efb7df: > Update go.mod dependencies > Update go.mod dependencies > Update go.mod dependencies > Update go.mod dependencies > Update go.mod dependencies > Update go.mod dependencies > Update go.mod dependencies > Update go.mod dependencies Submodule src/grootfs 42a1e710b..fedaee83d: > Update go.mod dependencies > Update go.mod dependencies > Update go.mod dependencies > Update go.mod dependencies > Update go.mod dependencies > Update go.mod dependencies > Update go.mod dependencies > Update go.mod dependencies > Update go.mod dependencies > Update go.mod dependencies > Update go.mod dependencies > Update go.mod dependencies > Update go.mod dependencies > Update go.mod dependencies > Update go.mod dependencies > Update go.mod dependencies > Update go.mod dependencies Submodule src/idmapper a4d1ca558..e2669a311: > Update go.mod dependencies > Update go.mod dependencies > Update go.mod dependencies > Update go.mod dependencies > Update go.mod dependencies > Update go.mod dependencies > Update go.mod dependencies > Update go.mod dependencies
kart2bc
pushed a commit
to kart2bc/diego-release
that referenced
this pull request
Aug 19, 2025
It seems like 20s not enough time to run migrations on mysql 8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the other etcd properties can be overridden in
property_overrides. We need to also be able to overrideproperties.etcd.machinesandproperties.diego.bbs.etcd.machinesin the same way.