Update bosh dance instructions #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current bosh dance instructions have the unfortunate consequence that if you don't have a config/dev.yml and copy/paste it, Bosh will prompt you for the name of the release and receive the `bosh -n upload release` as the input. This fixes it so the prompt correctly waits for input.
|
Hey benmoss! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you've already signed the CLA. |
|
We have created an issue in Pivotal Tracker to manage this. You can view the current status of your issue at: https://www.pivotaltracker.com/story/show/97149736. |
dsabeti
added a commit
to dsabeti/diego-release
that referenced
this pull request
Jan 30, 2023
Submodule src/code.cloudfoundry.org/buildpackapplifecycle 2b9331e66..9a09b9a51: > Merge pull request cloudfoundry#56 from dsabeti/fix-windows-tests > Merge pull request cloudfoundry#55 from dsabeti/fix-windows-tests > Merge pull request cloudfoundry#54 from dsabeti/test-refactor > Merge pull request cloudfoundry#53 from dsabeti/remove-unused-func Signed-off-by: Aram Price <[email protected]>
mariash
pushed a commit
that referenced
this pull request
Jan 30, 2023
Submodule src/code.cloudfoundry.org/buildpackapplifecycle 2b9331e66..9a09b9a51: > Merge pull request #56 from dsabeti/fix-windows-tests > Merge pull request #55 from dsabeti/fix-windows-tests > Merge pull request #54 from dsabeti/test-refactor > Merge pull request #53 from dsabeti/remove-unused-func Signed-off-by: Aram Price <[email protected]>
tas-runtime-bot
added a commit
that referenced
this pull request
May 6, 2024
Submodule src/code.cloudfoundry.org/credhub-cli 19663e8d3..ab16e480d: > Bump go modules Submodule src/code.cloudfoundry.org/rep 3983069..6ee2201: > Do not remove evacuating actual LRP during cleanup (#53) Submodule src/grootfs 8fe016ce5..5947fe78a: > Update go.mod dependencies Submodule src/guardian 0e263888e..50be6eaaf: > Update go.mod dependencies
appruntimeplatform-bot
pushed a commit
that referenced
this pull request
Jun 4, 2025
Submodule src/code.cloudfoundry.org/inigo f4eb115..7492fbf: > Update inigo's path for building gorouter (#53) Submodule src/garden d3475276d..2f07acb6e: > Update go.mod dependencies Submodule src/grootfs 01f30a7e4..2ab8f4e6b: > Update go.mod dependencies Submodule src/guardian af31d1ee6..30b5a859f: > Update go.mod dependencies Submodule src/idmapper b81cb7a80..dc852fc1b: > Update go.mod dependencies
kart2bc
pushed a commit
to kart2bc/diego-release
that referenced
this pull request
Aug 25, 2025
kart2bc
pushed a commit
to kart2bc/diego-release
that referenced
this pull request
Aug 25, 2025
Evacuating actual LRP will be removed by BBS convergence or after the replacement LRP is started. No need to bombard BBS during cell updates. This will minimize the drain time and it will actually stay close to the configured drain timeout. Cleanup is happening after the timeout is reached and BBS requests can overload BBS and cause it to timeout each request (10s) by default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current bosh dance instructions have the unfortunate consequence that if you don't have a config/dev.yml and copy/paste it, Bosh will prompt you for the name of the release and receive the
bosh -n upload releaseas the input. This fixes it so the prompt correctly waits for input.