cleanup rep require tls property #1021
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cf-foundation-community-automation
bot
moved this to Inbox
in Application Runtime Platform Working Group
ameowlia
requested changes
Jun 23, 2025
Member
ameowlia
left a comment
ameowlia
left a comment
There was a problem hiding this comment.
Did you deploy and test this? I am surprised this would have passed if there were no certs passed through.
Member
|
I also this the "RepRequireTLS" property is still used in the inigo and route-emitter submodules. |
ameowlia
approved these changes
Jun 27, 2025
github-project-automation
bot
moved this from Inbox
to Pending Merge | Prioritized
in Application Runtime Platform Working Group
github-project-automation
bot
moved this from Pending Merge | Prioritized
to Done
in Application Runtime Platform Working Group
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
cleanup rep require tls property
dep:
https://github.com/cloudfoundry/auctioneer/pull/23/files
cloudfoundry/bbs#113
cloudfoundry/inigo#57
cloudfoundry/route-emitter#51
cloudfoundry/rep#71
diego-log.txt
Attached logs for all tests except inigo due to limitation in local testing.
Backward Compatibility
Breaking Change? Yes