Make sure the DeclarativeHealthcheckPath is valid

see comments for further details

Author: jvshahid

world/components.go

@@ -694,15 +694,15 @@ func (maker commonComponentMaker) RouteEmitterN(n int, fs ...func(config *routee
 		BBSCACertFile:                      maker.bbsSSL.CACert,
 		CommunicationTimeout:               durationjson.Duration(30 * time.Second),
 		ConsulDownModeNotificationInterval: durationjson.Duration(time.Minute),
-		LockTTL:                            durationjson.Duration(locket.DefaultSessionTTL),
-		NATSUsername:                       "nats",
-		NATSPassword:                       "nats",
-		RouteEmittingWorkers:               20,
-		SyncInterval:                       durationjson.Duration(time.Minute),
-		TCPRouteTTL:                        durationjson.Duration(2 * time.Minute),
-		EnableTCPEmitter:                   false,
-		EnableInternalEmitter:              false,
-		RegisterDirectInstanceRoutes:       false,
+		LockTTL:                      durationjson.Duration(locket.DefaultSessionTTL),
+		NATSUsername:                 "nats",
+		NATSPassword:                 "nats",
+		RouteEmittingWorkers:         20,
+		SyncInterval:                 durationjson.Duration(time.Minute),
+		TCPRouteTTL:                  durationjson.Duration(2 * time.Minute),
+		EnableTCPEmitter:             false,
+		EnableInternalEmitter:        false,
+		RegisterDirectInstanceRoutes: false,
 	}
 
 	for _, f := range fs {
@@ -1327,6 +1327,14 @@ func (maker v1ComponentMaker) RepN(n int, modifyConfigFuncs ...func(*repconfig.R
 	cachePath := path.Join(tmpDir, "cache")
 	Expect(os.Mkdir(cachePath, 0777)).To(Succeed())
 
+	// garden 1.16.5 checks the source of the bind mount for mount options.
+	// Furthermore Rep in version 1.25.2 bind mounted the healthcheck binaries
+	// unconditionally without paying attention to
+	// EnableDeclarativeHealthcheck.  We need to ensure that the source exist.
+	// see
+	// https://github.com/cloudfoundry/guardian/commit/1407257d989b483c64ea7d7cb6ea7d071fa75e84
+	healthcheckDummyDir := TempDir("healthcheck")
+
 	repConfig := repconfig.RepConfig{
 		AdvertiseDomain:           "cell.service.cf.internal",
 		BBSClientSessionCacheSize: 0,
@@ -1361,6 +1369,7 @@ func (maker v1ComponentMaker) RepN(n int, modifyConfigFuncs ...func(*repconfig.R
 			ContainerReapInterval:              durationjson.Duration(time.Minute),
 			ContainerInodeLimit:                200000,
 			EnableDeclarativeHealthcheck:       false,
+			DeclarativeHealthcheckPath:         healthcheckDummyDir,
 			MaxCacheSizeInBytes:                10 * 1024 * 1024 * 1024,
 			SkipCertVerify:                     false,
 			HealthyMonitoringInterval:          durationjson.Duration(30 * time.Second),
@@ -1383,12 +1392,12 @@ func (maker v1ComponentMaker) RepN(n int, modifyConfigFuncs ...func(*repconfig.R
 			CSIPaths:                           []string{"/var/vcap/data/csiplugins"},
 			CSIMountRootDir:                    "/var/vcap/data/csimountroot",
 
-			EnableUnproxiedPortMappings:   true,
-			GardenNetwork:                 "tcp",
-			GardenAddr:                    maker.addresses.GardenLinux,
-			ContainerMaxCpuShares:         1024,
-			CachePath:                     cachePath,
-			TempDir:                       tmpDir,
+			EnableUnproxiedPortMappings: true,
+			GardenNetwork:               "tcp",
+			GardenAddr:                  maker.addresses.GardenLinux,
+			ContainerMaxCpuShares:       1024,
+			CachePath:                   cachePath,
+			TempDir:                     tmpDir,
 			GardenHealthcheckProcessPath:  "/bin/sh",
 			GardenHealthcheckProcessArgs:  []string{"-c", "echo", "foo"},
 			GardenHealthcheckProcessUser:  "vcap",
@@ -1428,6 +1437,7 @@ func (maker v1ComponentMaker) RepN(n int, modifyConfigFuncs ...func(*repconfig.R
 			"-config", configFile.Name()),
 		Cleanup: func() {
 			os.RemoveAll(tmpDir)
+			os.RemoveAll(healthcheckDummyDir)
 		},
 	})
 }