Set Routable to true for existing LRPs in Running state

Author: mariash

db/migrations/1686692176_add_routable_to_actual_lrps.go

@@ -42,16 +42,25 @@ func (e *AddRoutableToActualLrps) SetClock(c clock.Clock)    { e.clock = c }
 func (e *AddRoutableToActualLrps) SetDBFlavor(flavor string) { e.dbFlavor = flavor }
 
 func (e *AddRoutableToActualLrps) Up(logger lager.Logger) error {
-	logger.Info("altering the table", lager.Data{"query": alterActualLRPAddRoutableSQL})
-	_, err := e.rawSQLDB.Exec(alterActualLRPAddRoutableSQL)
-	if err != nil {
-		logger.Error("failed-altering-tables", err)
-		return err
+	var alterTablesSQL = []string{
+		alterActualLRPAddRoutableSQL,
+		alterActualLRPSetRoutableForRunningSQL,
+	}
+	for _, query := range alterTablesSQL {
+		logger.Info("altering the table", lager.Data{"query": query})
+		_, err := e.rawSQLDB.Exec(query)
+		if err != nil {
+			logger.Error("failed-altering-tables", err)
+			return err
+		}
+		logger.Info("altered the table", lager.Data{"query": query})
 	}
-	logger.Info("altered the table", lager.Data{"query": alterActualLRPAddRoutableSQL})
 
 	return nil
 }
 
 const alterActualLRPAddRoutableSQL = `ALTER TABLE actual_lrps
 ADD COLUMN routable BOOL DEFAULT false;`
+
+const alterActualLRPSetRoutableForRunningSQL = `UPDATE actual_lrps
+SET routable = true WHERE state = 'RUNNING';`

db/migrations/1686692176_add_routable_to_actual_lrps_test.go

@@ -64,7 +64,7 @@ var _ = Describe("AddRoutableToActualLrps", func() {
 			Expect(routable).To(BeTrue())
 		})
 
-		It("sets routable false for all existing actual_lrp rows", func() {
+		It("sets routable true for all existing actual_lrp rows in RUNNING state", func() {
 			_, err := rawSQLDB.Exec(
 				helpers.RebindForFlavor(
 					`INSERT INTO actual_lrps
@@ -79,6 +79,28 @@ var _ = Describe("AddRoutableToActualLrps", func() {
 
 			Expect(migration.Up(logger)).To(Succeed())
 
+			var routable bool
+			query := helpers.RebindForFlavor("select routable from actual_lrps limit 1", flavor)
+			row := rawSQLDB.QueryRow(query)
+			Expect(row.Scan(&routable)).To(Succeed())
+			Expect(routable).To(BeTrue())
+		})
+
+		It("sets routable false for all existing actual_lrp rows not in RUNNING state", func() {
+			_, err := rawSQLDB.Exec(
+				helpers.RebindForFlavor(
+					`INSERT INTO actual_lrps
+						(process_guid, instance_index, domain, state, net_info,
+						modification_tag_epoch, modification_tag_index)
+					VALUES (?, ?, ?, ?, ?, ?, ?)`,
+					flavor,
+				),
+				"guid-1", 10, "cfapps", "CLAIMED", "", "epoch", 0,
+			)
+			Expect(err).NotTo(HaveOccurred())
+
+			Expect(migration.Up(logger)).To(Succeed())
+
 			var routable bool
 			query := helpers.RebindForFlavor("select routable from actual_lrps limit 1", flavor)
 			row := rawSQLDB.QueryRow(query)