BAL works on windows2012R2 #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are two main changes that need to be made in order for the BAL to work on windows2012R2: 1. Because of the way "containers" are implemented (directories in c:\containerizer), we need to prepend the working directory of the process running builder.exe to all of the builder config paths 2. We can't assume that tar.exe is on the PATH. Instead, we will assume that it is next to the builder.exe file (i.e. in the same directory as all the other lifecycle binaries) There are now three ways to build the builder: 1. For linux 2. GOOS=windows -tags=windows2012R2 // for windows2012R2 3. GOOS=windows // for windows2016 When running the builder tests for windows2012R2, the environment variable TAR_URL must be set. The test suite will download this file and place it next to the builder.exe built by gexec.Build The tar.exe files that will be included in diego-release can be found here: https://greenhouse.ci.cf-app.com/teams/main/pipelines/tar/resources/s3-bucket No changes are required to the launcher. [#151173124] Signed-off-by: Sam Smith <[email protected]>
|
Hey sesmith177! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/151227754 The labels on this github issue will be updated when the story is started. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order for Diego instance identity credentials to work on windows2012R2, it will need to use the BAL instead of the .NET WAL.
There are two main changes that need to be made in order for the BAL to
work on windows2012R2:
Because of the way "containers" are implemented (directories in
c:\containerizer), we need to prepend the working directory of the
process running builder.exe to all of the builder config paths
We can't assume that tar.exe is on the PATH. Instead, we will
assume that it is next to the builder.exe file (i.e. in the same
directory as all the other lifecycle binaries)
As of this PR, there are now three ways to build the builder:
When running the builder tests for windows2012R2, the environment
variable TAR_URL must be set. The test suite will download this file and
place it next to the builder.exe built by gexec.Build
The tar.exe files that will be included in diego-release can be found
here: https://greenhouse.ci.cf-app.com/teams/main/pipelines/tar/resources/s3-bucket
No changes are required to the launcher.
[#151173124]
Signed-off-by: Sam Smith [email protected]