Merge pull request #47 from bengerman13/existing-user-new-space

acosta11 · web-flow · commit cf8305784c93 · 2019-12-16T12:09:33.000-08:00
don't skip space role creation on new spaces [finishes #170250877](https://www.pivotaltracker.com/story/show/170250877)
diff --git a/workflowhelpers/test_suite_setup.go b/workflowhelpers/test_suite_setup.go
@@ -109,7 +109,7 @@ func NewBaseTestSuiteSetup(config testSuiteConfig, testSpace internal.Space, tes
 		adminUserContext:   adminUserContext,
 
 		SkipUserCreation:      skipUserCreation,
-		SkipSpaceRoleCreation: !config.GetAddExistingUserToExistingSpace() && skipUserCreation,
+		SkipSpaceRoleCreation: !config.GetAddExistingUserToExistingSpace() && config.GetUseExistingSpace() && skipUserCreation,
 		TestSpace:             testSpace,
 		TestUser:              testUser,
 	}

Original file line number	Diff line number	Diff line change
`@@ -109,7 +109,7 @@ func NewBaseTestSuiteSetup(config testSuiteConfig, testSpace internal.Space, tes`
`109`	`109`	`adminUserContext: adminUserContext,`
`110`	`110`
`111`	`111`	`SkipUserCreation: skipUserCreation,`
`112`		`- SkipSpaceRoleCreation: !config.GetAddExistingUserToExistingSpace() && skipUserCreation,`
	`112`	`+ SkipSpaceRoleCreation: !config.GetAddExistingUserToExistingSpace() && config.GetUseExistingSpace() && skipUserCreation,`
`113`	`113`	`TestSpace: testSpace,`
`114`	`114`	`TestUser: testUser,`
`115`	`115`	`}`