Fix silent failure when browser open doesn't work (#263)

* Fix the error case when "open" fails It's the returned child process that throws an error, not the launching function itself * Fixing accidental console log * Adding changeset and fixing formatting * Update pages.tsx Co-authored-by: Sunil Pai <[email protected]>
cloudflare · Jan 18, 2022 · 402c77d · 402c77d
1 parent 2a89ee5
commit 402c77d
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/.changeset/tricky-lemons-warn.md b/.changeset/tricky-lemons-warn.md
@@ -0,0 +1,5 @@
+---
+"wrangler": patch
+---
+
+fix: appropriately fail silently when the open browser command doesn't work
diff --git a/packages/wrangler/src/pages.tsx b/packages/wrangler/src/pages.tsx
@@ -938,9 +938,9 @@ export const pages: BuilderCallback<unknown, unknown> = (yargs) => {
           console.log(`Serving at http://127.0.0.1:${port}/`);
 
           if (process.env.BROWSER !== "none") {
-            try {
-              await open(`http://127.0.0.1:${port}/`);
-            } catch {}
+            const childProcess = await open(`http://127.0.0.1:${port}/`);
+            // fail silently if the open command doesn't work (e.g. in GitHub Codespaces)
+            childProcess.on("error", (_err) => {});
           }
 
           if (directory !== undefined && liveReload) {