This repository has been archived by the owner on Aug 3, 2023. It is now read-only.
Proxy websocket connections when using authenticated (realish) preview #2135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Returning a `Request` instead of a future allows passing the request to tungstenite to open a websocket. This also changes the `Request` parameter to be a parts and body, to avoid needless `Request::from_parts/to_parts` calls.
Previously, Wrangler would return a "101 Switching Protocols" request and then immediately close the TCP connection. This changes it to instead continue proxying the connection to the remote worker. This is simpler than `wrangler dev --inspect` (and uses a different codepath) because it only proxies the TCP connection directly rather than trying to inspect each websocket message. # How do I use this? 1. Create a worker that uses WebSockets. I used https://github.com/cloudflare/websocket-template with the `protocol` in template.js changed from `wss` to `ws`. 2. Run `wrangler dev http http`. Note that `wrangler dev` (i.e. with the default of `https` for the upstream connection) requires you to first deploy the worker at least once. Without deploying, the remote worker won't receive the `Connection: Upgrade` and `Upgrade: Websocket` headers. Unauthenticated preview is not currently supported.
jyn514
force-pushed
the
jnelson/websockets
branch
from
d8949d0 to
ecc63f7
Compare
Electroid
approved these changes
Nov 19, 2021
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, Wrangler would return a "101 Switching Protocols" response
and then immediately close the TCP connection. This changes it to instead
continue proxying the connection to the remote worker.
This is simpler than
wrangler dev --inspect(and uses a different codepath) because it onlyproxies the TCP connection directly rather than trying to inspect each websocket message.
How do I use this?
protocolin template.js changed fromwsstows.wrangler dev http http.Note that
wrangler dev(i.e. with the default ofhttpsfor the upstream connection) is currently broken. I am looking into this internally; it's an issue with the Cloudflare edge network and not with wrangler.Unauthenticated preview is not currently supported.
Helps with #2079 and #1910.