Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not consider ancestor files when initializing a project with a specified name #1269

Merged
merged 3 commits into from
Jun 17, 2022
Merged

fix: do not consider ancestor files when initializing a project with a specified name #1269

merged 3 commits into from
Jun 17, 2022

Commits on Jun 15, 2022

  1. test: add checks for unused mock dialogs in tests

    @petebacondarwin
    petebacondarwin committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    133dadc View commit details
    Browse the repository at this point in the history

  2. test: refactor init tests to use file-system helpers

    @petebacondarwin
    petebacondarwin committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    c4d71cc View commit details
    Browse the repository at this point in the history

  3. fix: do not consider ancestor files when initializing a project with … 

    …a specified name

When initializing a new project (via `wrangler init`) we attempt to reuse files in the current
directory, or in an ancestor directory. In particular we look up the directory tree for
package.json and tsconfig.json and use those instead of creating new ones.

Now we only do this if you do not specify a name for the new Worker. If you do specify a name,
we now only consider files in the directory where the Worker will be initialized.

Fixes cloudflare#859
    @petebacondarwin
    petebacondarwin committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    43ec49b View commit details
    Browse the repository at this point in the history