Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: trying to use node builtins should log a message recommending to try node_compat = true #989

Closed
threepointone opened this issue May 13, 2022 · 0 comments · Fixed by #1027
Closed

feat: trying to use node builtins should log a message recommending to try node_compat = true #989

threepointone opened this issue May 13, 2022 · 0 comments · Fixed by #1027
Assignees
@rozenmd
Labels
enhancement New feature or request

Comments

@threepointone
Copy link
Contributor

When you try to use a node builtin right now, esbuild logs an error about setting platform to node. The message should instead recommend setting node_compat = true in their wrangler.toml
@threepointone threepointone added the enhancement New feature or request label May 13, 2022
@threepointone threepointone added this to the 2.1 milestone May 13, 2022
@rozenmd rozenmd self-assigned this May 13, 2022
@petebacondarwin petebacondarwin moved this to Selected for development in workers-sdk May 15, 2022
@petebacondarwin petebacondarwin removed this from the Selected for development milestone May 15, 2022
@rozenmd rozenmd mentioned this issue May 16, 2022
Merged
2 tasks
Repository owner moved this from Selected for development to Done in workers-sdk May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rozenmd rozenmd

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: recommend node compat on builtin use cloudflare/workers-sdk
3 participants
@petebacondarwin @threepointone @rozenmd